From owner-svn-ports-all@FreeBSD.ORG  Tue May  6 11:57:23 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 17A871E9;
 Tue,  6 May 2014 11:57:23 +0000 (UTC)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 05081E0C;
 Tue,  6 May 2014 11:57:23 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.8/8.14.8) with ESMTP id s46BvMCT070781;
 Tue, 6 May 2014 11:57:22 GMT (envelope-from tijl@svn.freebsd.org)
Received: (from tijl@localhost)
 by svn.freebsd.org (8.14.8/8.14.8/Submit) id s46BvM6J070779;
 Tue, 6 May 2014 11:57:22 GMT (envelope-from tijl@svn.freebsd.org)
Message-Id: <201405061157.s46BvM6J070779@svn.freebsd.org>
From: Tijl Coosemans <tijl@FreeBSD.org>
Date: Tue, 6 May 2014 11:57:22 +0000 (UTC)
To: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: svn commit: r353084 - in head/Mk: . Scripts
X-SVN-Group: ports-head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 May 2014 11:57:23 -0000

Author: tijl
Date: Tue May  6 11:57:22 2014
New Revision: 353084
URL: http://svnweb.freebsd.org/changeset/ports/353084
QAT: https://qat.redports.org/buildarchive/r353084/

Log:
  Let stage-qa detect .la libraries and warn that a port needs USES=libtool.
  
  PR:		ports/189255
  Approved by:	portmgr (antoine)

Modified:
  head/Mk/Scripts/qa.sh
  head/Mk/bsd.stage.mk

Modified: head/Mk/Scripts/qa.sh
==============================================================================
--- head/Mk/Scripts/qa.sh	Tue May  6 11:17:29 2014	(r353083)
+++ head/Mk/Scripts/qa.sh	Tue May  6 11:57:22 2014	(r353084)
@@ -172,7 +172,18 @@ suidfiles() {
 	return 0
 }
 
-checks="shebang symlinks paths stripped desktopfileutils sharedmimeinfo suidfiles"
+libtool() {
+	if [ -z "${USESLIBTOOL}" ]; then
+		find ${STAGEDIR} -type f -name '*.la' | while read f; do
+			grep -q 'libtool library' "${f}" &&
+				warn ".la libraries found, port needs USES=libtool" &&
+				return 0 || true
+		done
+		# The return above continues here.
+	fi
+}
+
+checks="shebang symlinks paths stripped desktopfileutils sharedmimeinfo suidfiles libtool"
 
 ret=0
 cd ${STAGEDIR}

Modified: head/Mk/bsd.stage.mk
==============================================================================
--- head/Mk/bsd.stage.mk	Tue May  6 11:17:29 2014	(r353083)
+++ head/Mk/bsd.stage.mk	Tue May  6 11:57:22 2014	(r353084)
@@ -17,6 +17,9 @@ QA_ENV+=	STAGEDIR=${STAGEDIR} \
 .if !empty(USES:Mdesktop-file-utils)
 QA_ENV+=	USESDESKTOPFILEUTILS=yes
 .endif
+.if !empty(USES:Mlibtool*)
+QA_ENV+=	USESLIBTOOL=yes
+.endif
 .if !empty(USES:Mshared-mime-info)
 QA_ENV+=	USESSHAREDMIMEINFO=yes
 .endif