From owner-cvs-src@FreeBSD.ORG Wed Nov 29 11:04:58 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 084BA16A407; Wed, 29 Nov 2006 11:04:58 +0000 (UTC) (envelope-from Danovitsch@vitsch.net) Received: from amsfep17-int.chello.nl (amsfep19-int.chello.nl [213.46.243.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id C111343CA5; Wed, 29 Nov 2006 11:04:55 +0000 (GMT) (envelope-from Danovitsch@vitsch.net) Received: from Tuinhuisje.Vitsch.net ([62.195.87.223]) by amsfep17-int.chello.nl (InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id <20061129110453.VJER10644.amsfep17-int.chello.nl@Tuinhuisje.Vitsch.net>; Wed, 29 Nov 2006 12:04:53 +0100 Received: from self (f23025.upc-f.chello.nl [80.56.23.25]) (authenticated bits=0) by Tuinhuisje.Vitsch.net (8.13.1/8.13.1) with ESMTP id kATB4e3i093401; Wed, 29 Nov 2006 12:04:44 +0100 (CET) (envelope-from Danovitsch@vitsch.net) From: "Daan Vreeken [PA4DAN]" Organization: Vitsch Electronics To: Ian Dowse , cvs-src@freebsd.org, "M. Warner Losh" , scottl@samsco.org, src-committers@freebsd.org, cvs-all@freebsd.org, marius@alchemy.franken.de Date: Wed, 29 Nov 2006 12:04:43 +0100 User-Agent: KMail/1.9.1 References: <200611291058.aa80677@nowhere.iedowse.com> In-Reply-To: <200611291058.aa80677@nowhere.iedowse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611291204.43704.Danovitsch@vitsch.net> Cc: Subject: Re: cvs commit: src/sys/dev/usb usbdi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2006 11:04:58 -0000 Hi Ian, On Wednesday 29 November 2006 11:58, you wrote: > In message <200611281453.26820.Danovitsch@vitsch.net>, "Daan Vreeken > [PA4DAN]" > > writes: > >I don't believe my patch is at the right place where it's placed now. Any > >ideas from someone with more bus_dma-foo and/or usb-foo are highly > >appreciated :) > >If more debugging information is needed, just ask. > > Hi Daan, > > Thanks for all the details - I'll try to put together a patch in the > next few days that adds bus_dmamap_sync() calls whereever there are > shared access ordering requirements in the host controller drivers. > As Olivier mentioned, bus_dma(9) says that this should be done even > for BUS_DMA_COHERENT allocations, so adding them may fix problems on > other platforms too. > > BTW it looks like some of the packet descriptor structures in the > HC drivers currently throw away their bus_dma information, since > the strutures are never freed, so adding the bus_dmamap_sync() calls > will involve keeping track of them now. Ok, thanks for looking into this! At the moment I'm working on a driver for the USB device port that's on the ARM board. The driver is about half way being usefull. Once it's finished I can debug USB problems from the device perspective and see what data actually goes over the wire. That should show us what exactly goes wrong without the bus_dmapmap_sync() calls. -- Daan