Date: Sat, 04 Mar 2017 13:14:41 -0800 From: Cy Schubert <Cy.Schubert@komquats.com> To: Ngie Cooper <ngie@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314676 - in head/usr.sbin/amd: amd libamu Message-ID: <201703042114.v24LEfqZ098918@slippy.cwsent.com> In-Reply-To: Message from Ngie Cooper <ngie@FreeBSD.org> of "Sat, 04 Mar 2017 20:35:34 %2B0000." <201703042035.v24KZYUv058554@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <201703042035.v24KZYUv058554@repo.freebsd.org>, Ngie Cooper writes: > Author: ngie > Date: Sat Mar 4 20:35:34 2017 > New Revision: 314676 > URL: https://svnweb.freebsd.org/changeset/base/314676 > > Log: > Fix build after r314656 > > Some of the changes I introduced to use .ALLSRC were correct in spirit, > but incorrect in reality -- in particular, ../Makefile.inc hadn't been > pulled in via bsd.init.mk (via bsd.lib.mk, bsd.prog.mk), so the value > of .ALLSRC (evaluated immediately) was empty. .include bsd.init.mk > explicitly so we can be certain that the values used as dependencies in > the targets are defined when the target recipe has been evaluated. > > Reminder: thou shalt separate out separate functional changes before > committing them. > > (YUGE) Pointyhat to: ngie > In collaboration with: bdrewery > MFC after: 1 month > Reported by: Jenkins, cy, ler,O. Hartmann , Michael Butler Actually, I didn't report anything. I simply replied to O. Hartmann's email that it was failing to link to rpcsvc. Good to see it's fixed. The NFS RPC relationship makes amd a little tricky. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201703042114.v24LEfqZ098918>