Date: Sun, 6 May 2018 17:47:46 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: Alexey Dokuchaev <danfe@FreeBSD.org>, Koichiro Iwao <meta@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r469188 - head/ports-mgmt/pkg_replace Message-ID: <20180506154746.ujhfgfkap2dxlgbc@ivaldir.net> In-Reply-To: <612D8486-6A77-4CBD-8276-AFE53DF2AC92@adamw.org> References: <201805061015.w46AF3HQ070595@repo.freebsd.org> <20180506102749.GA58637@FreeBSD.org> <CC3C2D9C-F9B7-48DE-A53B-D9193C6CE65E@adamw.org> <20180506150441.52w3lodurubkz2lb@ivaldir.net> <612D8486-6A77-4CBD-8276-AFE53DF2AC92@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--6kodasuenwncgxqr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 06, 2018 at 09:45:34AM -0600, Adam Weinberger wrote: > > On 6 May, 2018, at 09:04, Baptiste Daroussin <bapt@FreeBSD.org> wrote: > >=20 > > On Sun, May 06, 2018 at 08:41:36AM -0600, Adam Weinberger wrote: > > > > On 6 May, 2018, at 04:27, Alexey Dokuchaev <danfe@FreeBSD.org> wrot= e: > > > >=20 > > > > On Sun, May 06, 2018 at 10:15:03AM +0000, Koichiro Iwao wrote: > > > > > New Revision: 469188 > > > > > URL: https://svnweb.freebsd.org/changeset/ports/469188 > > > > >=20 > > > > > Log: > > > > > ports-mgmt/pkg_replace: Update to 20180424 > > > > >=20 > > > > > - Cleanup code > > > > > - Speed up and strictly check package's dependencies > > > > > - While here, pet portlint by using pkg-plist instead of PLIST_= FILES > > > >=20 > > > > Could you explain what did you achieve by moving three-line PLIST_F= ILES > > > > into pkg-plist? How can "pet portlint" be a reason for a change wh= ile > > > > we generally encourage converting <6-line pkg-plist's into PLIST_FI= LES? > > > >=20 > > > > ./danfe > > > >=20 > > > > > - > > > > > -PLIST_FILES=3D sbin/pkg_replace \ > > > > > - man/man1/pkg_replace.1.gz \ > > > > > - "@sample %%ETCDIR%%/pkg_replace.conf.sample" > > > >=20 > > > > Correct PLIST_FILES should read: > > > >=20 > > > > PLIST_FILES=3D sbin/pkg_replace \ > > > > man/man1/pkg_replace.1.gz \ > > > > @sample\ etc/pkg_replace/pkg_replace.conf.sample > > > >=20 > > > > ./danfe > > >=20 > > > Sorry, Alexey, but portlint was right here. @sample and other macros > > > should > > > *never* appear in PLIST_FILES. Even if the port installs only a > > > single file, > > > if it=E2=80=99s a @sample, it goes in pkg-plist. > > Same why :) > >=20 > > Alexey is wrong imho about the '\' the quotes where fine, but he is > > right about > > the replacement of the %%ETCDIR%%. > >=20 > > I don't understand why keywords should be forbiddent in PLIST_FILES mac= ros? > >=20 > > The framework itself uses macros in PLIST_FILES >=20 > Oh, my. I thought this was a thing! I was so certain that this was (at le= ast > at one time) policy. Did this change, or did I just invent the whole thin= g? I never heard about it, but I have lost track of things for quite some time= , so maybe it happened at some point, and if that is the case, I would be curiou= s of the rational :) Bapt --6kodasuenwncgxqr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlrvI6IACgkQY4mL3PG3 Plo0nw/+OGJq3N/5B5ffz0iLMAlSV0w+5Ofczc1Ql8vzdHj4SlJj9UBKrUzLu1wa SgXRyBUVZvP8KQd68Vyo553VeiOt+xK9jT+dbYviEK8gy5xdAqnOrOTPjefdtGFR n52d7GS1IgOYOkR4XsbEwsjbC6nTiSkLdsMK1uGnLvLHghoXh7PTgVrxU8KtmRMC PUtCQ1qRUJX2nGqqjrX77lCmefUgnwe61n9Y/nFKQAhJsCymEypMIVb3HWym1VdF w7uhbNsRkXZ8o+T93trAnv8QmQLN++k71C8Ou3GQwPPYsVxVb6B9M0ywWga9AXIZ k5F77JiwRF8z7FcZDWEYtUIasjxhvUXJFIUZVrvJO4s/yvyhiOi3FELEguaF3YWZ R6Yy99OpYmgZM87rHVdUYAd2bo3Dpr1V345r5x5gDg3/5dGkYW4kIOusxCcBy+w/ rr6dK1BWlapxKQqMrm/ObD6vxA8rW31EnaMt9ed9jcR/T3UdUZEyhV4VpRIuNJCu CGRITKJgzlexrkQTnLBoobn+Xuar8sQkFKbm9UEmRvz64jtO/+3/YzEV6LgpmZy5 pnNyTyY37DmXz6DhJdji4Rrp3iWkTVF5uhV1P/LqDy+/cebzZmHhor2jPHc5fkR2 pBPq6BYWhCYjnJe4ZYhWIUhRpiNEPO9Q2uzESYyhsK6u3ABywnM= =wFKd -----END PGP SIGNATURE----- --6kodasuenwncgxqr--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180506154746.ujhfgfkap2dxlgbc>