From owner-cvs-src@FreeBSD.ORG  Tue Jan 25 13:05:52 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 680)
	id F245D16A4CF; Tue, 25 Jan 2005 13:05:51 +0000 (GMT)
Date: Tue, 25 Jan 2005 13:05:51 +0000
From: Darren Reed <darrenr@hub.freebsd.org>
To: Giorgos Keramidas <keramida@ceid.upatras.gr>
Message-ID: <20050125130551.GA91763@hub.freebsd.org>
References: <200501080432.j084W2BG093532@repoman.freebsd.org>
	<Pine.BSF.4.53.0501082112231.67312@e0-0.zab2.int.zabbadoz.net>
	<20050109231923.GG832@gothmog.gr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050109231923.GG832@gothmog.gr>
User-Agent: Mutt/1.4.2.1i
cc: Darren Reed <darrenr@freebsd.org>
cc: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: cvs-src@freebsd.org
Subject: Re: cvs commit: src/sys/contrib/ipfilter/netinet fil.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jan 2005 13:05:52 -0000

On Mon, Jan 10, 2005 at 01:19:23AM +0200, Giorgos Keramidas wrote:
> On 2005-01-08 21:14, "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> wrote:
> > On Sat, 8 Jan 2005, Darren Reed wrote:
> > > darrenr     2005-01-08 04:32:02 UTC
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     sys/contrib/ipfilter/netinet fil.c
> > >   Log:
> > >   Elminate 1 LOR (actually a recursive mutex grab) involving ipfilter where
> > >   we loop through all the list of NICs (struct ifnet), holding the lock on
> > >   it and then do a name lookup with ifunit() whilst holding it.
> > >
> > >   Revision  Changes    Path
> > >   1.43      +2 -25     src/sys/contrib/ipfilter/netinet/fil.c
> >
> > could you please tellme which one of the the three 50-52 of
> > 	http://sources.zabbadoz.net/freebsd/lor.html
> > got fixed with this commit so I can update the state?
> 
> I don't think it's listed there, as it's not a LOR per se.  No recursive
> mutex acquisitions are listed in the URL above.

I believe the patch fixes this -
http://sources.zabbadoz.net/freebsd/lor.html#050
- which is a recursive mutex problem, too.

Darren