From owner-cvs-src@FreeBSD.ORG Wed Sep 6 15:12:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B8D116A4DA; Wed, 6 Sep 2006 15:12:55 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 69B0C43D53; Wed, 6 Sep 2006 15:12:51 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k86FCkLF007600 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 6 Sep 2006 19:12:46 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k86FCk45007599; Wed, 6 Sep 2006 19:12:46 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 6 Sep 2006 19:12:46 +0400 From: Gleb Smirnoff To: Mike Silbersack Message-ID: <20060906151246.GU40020@FreeBSD.org> References: <200609061356.k86DuZ0w016069@repoman.freebsd.org> <20060906091204.B6691@odysseus.silby.com> <20060906143204.GQ40020@FreeBSD.org> <20060906093553.L6691@odysseus.silby.com> <20060906150129.GT40020@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20060906150129.GT40020@FreeBSD.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet in_pcb.c tcp_subr.c tcp_timer.c tcp_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2006 15:12:55 -0000 followup on my last email: T> I think we should free the oldmost tcptw entry in a case if we can't T> find the local endpoint. We can tell definitely that we can't find one T> only in in_pcbbind_setup() in the "do {} while (in_pcblookup_local)" cycle, T> where EADDRNOTAVAIL is returned. We can't definitely tell this in T> in_pcblookup_local() since we don't know whether tried port is the T> last one. Another simple enough solution would be to msleep() with tcbinfo mutex temporarily dropped if we fail to find a port. Then the tcp_timer_2msl_tw() on the next run will free tcptw entries and wake up us. Anyway, I'm strongly against doing the purge cycling in the syscalls. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE