Date: Thu, 8 Apr 2010 18:43:54 +0200 From: Rafal Jaworowski <raj@semihalf.com> To: John Baldwin <jhb@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 176621 for review Message-ID: <5E88AD5A-D59E-4C29-9E98-632C70D02500@semihalf.com> In-Reply-To: <201004080857.53917.jhb@freebsd.org> References: <201004071502.o37F2Rou064473@repoman.freebsd.org> <201004080857.53917.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2010-04-08, at 14:57, John Baldwin wrote: > On Wednesday 07 April 2010 11:02:27 am Rafal Jaworowski wrote: >> http://p4web.freebsd.org/@@176621?ac=3D10 >>=20 >> Change 176621 by raj@raj_fdt on 2010/04/07 15:02:20 >>=20 >> Provide PCI-E defines. >>=20 >> Affected files ... >>=20 >> .. //depot/projects/fdt/sys/dev/pci/pcireg.h#3 edit >>=20 >> Differences ... >>=20 >> =3D=3D=3D=3D //depot/projects/fdt/sys/dev/pci/pcireg.h#3 (text+ko) = =3D=3D=3D=3D >>=20 >> @@ -218,6 +218,17 @@ >>=20 >> #define PCIR_PCCARDIF_2 0x44 >>=20 >> + >> +/* PCIE registers */ >> +#define PCIR_DCR 0x54 >> +#define PCIM_DCR_URR 0x0008 >> +#define PCIM_DCR_FER 0x0004 >> +#define PCIM_DCR_NFER 0x0002 >> +#define PCIR_DSR 0x56 >> +#define PCIR_LTSSM 0x404 >> +#define PCIM_LTSSM_L0 0x16 >=20 > Err, are you sure about these? Generally the PCI-e registers are part = of the=20 > PCI-e capability and are not a fixed offset. Also, we already have = constants=20 > for various PCI-e registers in pcireg.h like so: >=20 > /* PCI Express definitions */ Thanks for pointing out. Let me look into improving and cleaning up this = (primarily I was just moving existing defines which we had locally in = mpc85xx PCI into a shared location without too deep thought). Rafal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5E88AD5A-D59E-4C29-9E98-632C70D02500>