From owner-svn-src-all@freebsd.org Mon Jan 13 18:31:05 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D6C2F1E78E5 for ; Mon, 13 Jan 2020 18:31:05 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47xMbs13sdz40xb for ; Mon, 13 Jan 2020 18:31:04 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1578940263; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=vN1bdST37tMgGxhPx4C+EQLYdOj1+bH6ai+gScLns/g/h382N2TpzPcrYewsxC8ic0Yj8Rd+gPxK3 gjvAPLcbgKDTEGvQmMz/nCGtUaPSIXyltqw6Osj/kZL6XSIF8dVpJWFydRSEfxac1zDsg/JJ5l+A/q 2M1VKs+KdCag8gwz2f66KaN2kjza4qj5EOsjfiGrwWDpX1ogA23xtFSPtse6xCmTzvK67hE6qZqTvk IK9T+lSom2JLJnRLocOnPcJ1T3JA+OmtfebB4ATtOpMHKAPNpa9vGl7iWdaFBxJh7zPM3kmPVLwTLP NXH/Ee2HEchVRI4Q5gmOEP2qPPorYdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=ciP+eh26h/khVCBT/4cz6qxbcXgErNlq6tPwU2CJ0CY=; b=vVznAiwWIoqYfAud8b4/Ab5rEo5cvC6K1HaC+24RX1lMCNl3UupVonvsHQx1NVAX40XImUN+AsG1B At4J2NFSAFWihdsNrWWgwEfi4D1R8NjTkx9cyW2De5YHcLSypgZT//5GbqBtAqKBk/bz8hh7/yk/aR xYTjBkkpEBs5OLGJ0Tz42Pski6P0MRWeXNm/l21LALiVHZWrXypC5d9InECrwoqRi4L8UXgAGlIbc+ AcFRTL1fQOJfmweZaKKCIJx++VGF26fcMG3xdcZzxUZVVagBy0HergaWcrE2mpItMaP4ogE/RcYjAi /21bBFZ9soPEhRhtQtqsJ9GYwzt2Fsg== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=ciP+eh26h/khVCBT/4cz6qxbcXgErNlq6tPwU2CJ0CY=; b=kCeA9w65RpqYMfiOrw59pWbR7v7AgmOJgOC5GVlXFpldLtQKtFMJhRoq0fp9h7NbtZ8Ly0ERzsffI R41ygHAB888Hka/TS7Huos3lcc6ZKBowmv27Leo/8NSFgdvH0UaAFIb6TysMqfXxcYC7UJQIx+57ak VdVhO2N0ChLQqQVqq9iuOtd2DU2cc3ooMNptM2rr4sfOQT0uf9zo4xBKSfV2//E2h4j60JwrefsUIN lZuUJpomBKbMP3fRy7g5HgBGCQ7pSXqeaPlDaPkmzFc8Kah7OPPJNXnbgY0pFlWo+5snynmpoiiVl0 HP9vMhIwW+xbRC7mgkDl0VNjQkLShOg== X-MHO-RoutePath: aGlwcGll X-MHO-User: d9855afa-3632-11ea-b80d-052b4a66b6b2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id d9855afa-3632-11ea-b80d-052b4a66b6b2; Mon, 13 Jan 2020 18:31:02 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 00DIV1Ns055383; Mon, 13 Jan 2020 11:31:01 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <5a3e388ed5c91a6d1f88ecc91c08dc103d0369d1.camel@freebsd.org> Subject: Re: svn commit: r356693 - in head/stand: efi/libefi i386/libi386 libofw uboot/lib From: Ian Lepore To: Toomas Soome , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Mon, 13 Jan 2020 11:31:01 -0700 In-Reply-To: <202001131822.00DIMtrW016338@repo.freebsd.org> References: <202001131822.00DIMtrW016338@repo.freebsd.org> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47xMbs13sdz40xb X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.99)[-0.987,0]; NEURAL_HAM_LONG(-0.99)[-0.992,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2020 18:31:05 -0000 On Mon, 2020-01-13 at 18:22 +0000, Toomas Soome wrote: > Author: tsoome > Date: Mon Jan 13 18:22:54 2020 > New Revision: 356693 > URL: https://svnweb.freebsd.org/changeset/base/356693 > > Log: > loader: allocate properly aligned buffer for network packet > > Use memalign(4, size) to ensure we have properly aligned buffer. > > MFC after: 2 weeks > > Modified: > head/stand/efi/libefi/efinet.c > head/stand/i386/libi386/pxe.c > head/stand/libofw/ofw_net.c > head/stand/uboot/lib/net.c > The malloc implementation in libstand already g'tees minimum alignment of 16 bytes on most arches, 64 bytes on arches that use u-boot (see libsa/zalloc_defs.h). So how does this change anything? -- Ian