Date: Wed, 14 Apr 2004 22:56:33 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: =?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?= <des@des.no> Cc: Tim Kientzle <kientzle@freebsd.org> Subject: Re: cvs commit: src/usr.bin/tar bsdtar.c bsdtar.h write.c Message-ID: <20040414224330.Q3533@gamplex.bde.org> In-Reply-To: <xzpisg292tp.fsf@dwp.des.no> References: <200404140040.i3E0esil061104@repoman.freebsd.org> <20040414021526.GB63832@elvis.mu.org> <20040414093706.GB65853@regency.nsu.ru> <xzpisg292tp.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 14 Apr 2004, [iso-8859-1] Dag-Erling Sm=F8rgrav wrote: > Alexey Dokuchaev <danfe@nsu.ru> writes: > > On Tue, Apr 13, 2004 at 07:15:26PM -0700, Alfred Perlstein wrote: > > > While I applaud the effort here, it is a major violation of C > > > POLA to have compilable code within a header file. > > Seconded. Please keep *.h code-free. > > What are you guys all smoking? Did you even look at the file in > question? The file does claim to do bad things in a comment: % /* Data for exclusion/inclusion handling: defined in matching.c */ % struct matching; % struct links_entry; % struct archive_dir_entry; Contrary to the comment, there is no data definition or even data declaration here, There are only bogus unsorted forward declarations here. These style bugs are not new; they were in rev.1.1. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040414224330.Q3533>