Date: Wed, 29 May 2019 13:08:59 -0400 From: Ed Maste <emaste@freebsd.org> To: Grzegorz Junka <list1@gjunka.com> Cc: freebsd-git@freebsd.org Subject: Re: Git handling of commit times Message-ID: <CAPyFy2CkyET7v6hTfhv8ZQ=%2BSYM_yyhtBwzM3GfS3funaDBZHQ@mail.gmail.com> In-Reply-To: <6fb4c8cb-7f59-872e-4de6-a8a02e7c4e29@gjunka.com> References: <8697933A-B813-4088-90B7-A84589C3CD33@freebsd.org> <CAPyFy2Bqg6m8D6rO%2Bg87Wk74iBYOGfq%2B=t6B_VhUM26mUZXO%2BQ@mail.gmail.com> <6fb4c8cb-7f59-872e-4de6-a8a02e7c4e29@gjunka.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 29 May 2019 at 11:40, Grzegorz Junka <list1@gjunka.com> wrote: > > Timestamp alone doesn't give much information. What matters is when the > branch in which the commit was added has been merged with other branches > (shown as merge commits in the history). Our history is mostly devoid of merges though, but your broader point is certainly valid - the relationship that's actually important is the parent/child commits, not the order of either date stamp. > Bear in mind that commits are local (by the virtue of git being > distributed scm). You can certainly write a git hook that verifies local > time to be approximately the same as server time and stop the commit if > that's not the case. But that's clunky and patronizing in my opinion\ > (e.g. someone won't be able to commit when on a train and off the grid). I'm not suggesting that we require the commit time to be close to the server time, just that we could disallow two actually invalid cases: - commit time is earlier than parent(s) - commit time is later than the (accurate) server time If you have local commits made while on the train and someone else pushes to the canonical repository before you're back online you're going to have to merge or rebase, and will then have an updated commit time. The solution to this issue triggering is easy - just make sure the client has the correct time. > Git commits are joined by hashes, timestamp is only some metadata. It > makes sens to talk about amount of commits since a particular hash but > not so much about amount of commits since a particular date. Indeed, but that said developers like to think in terms like "commits since a particular date", and we should provide a good experience there if we can do so without restricting realistic workflows.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2CkyET7v6hTfhv8ZQ=%2BSYM_yyhtBwzM3GfS3funaDBZHQ>