Date: Thu, 2 Oct 2014 01:27:47 +0400 From: "Alexander V. Chernikov" <melifaro@ipfw.ru> To: "Alexander V. Chernikov" <melifaro@FreeBSD.org> Cc: Rumen Telbizov <telbizov@gmail.com>, "freebsd-stable@freebsd.org" <freebsd-stable@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, brian@freebsd.org Subject: Re: 10.1-BETA2 possible kernel memory leak in routing table Message-ID: <7AB35136-89AA-48F2-8B0E-1BA3DCD4A6BA@ipfw.ru> In-Reply-To: <542C5529.9030800@FreeBSD.org> References: <CAENR%2B_UVLDDrsef2W4CXCFX65EYaxeKN4MNWbgoyaZ5qDGe1Pg@mail.gmail.com> <542AAA3C.1080803@ipfw.ru> <CAENR%2B_X5KTdeb00f9NShN1YK%2BT2aY1vG5YcTCgu4aXZO=%2Bpa=g@mail.gmail.com> <542AE376.6000003@FreeBSD.org> <CAENR%2B_XX4jnD6SBi8S1dGfWM68tmcm0aE2iMVA3LDR3R8ygQYw@mail.gmail.com> <542AFAE3.9030705@FreeBSD.org> <CAENR%2B_WbntqjE4b=iZS8z30AK7gSpur00HsWP9-T_UJ7OosU8Q@mail.gmail.com> <20141001135124.GM73266@glebius.int.ru> <542C20D7.3070606@sentex.net> <20141001171646.GQ73266@glebius.int.ru> <CAENR%2B_VwWor23sX4WAfzU18z8mdRxGverUsCKcjO=L3DVSuq6g@mail.gmail.com> <542C5529.9030800@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01 Oct 2014, at 23:25, Alexander V. Chernikov <melifaro@FreeBSD.org> = wrote: > On 01.10.2014 22:49, Rumen Telbizov wrote: >> Submitted PR with details at = https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D194078 >>=20 >>=20 >> On Wed, Oct 1, 2014 at 10:16 AM, Gleb Smirnoff <glebius@freebsd.org = <mailto:glebius@freebsd.org>> wrote: >>=20 >> On Wed, Oct 01, 2014 at 11:42:15AM -0400, Mike Tancsa wrote: >> M> On 10/1/2014 9:51 AM, Gleb Smirnoff wrote: >> M> > On Tue, Sep 30, 2014 at 04:56:00PM -0700, Rumen Telbizov = wrote: >> M> > R> Brian Somers and I are currently looking into the source >> of PF in latest >> M> > R> 10-STABLE and trying to figure out what is going on. We >> were able to >> M> > R> replicate this problem on a 11-CURRENT (Sep 12th) machine >> as well. A simple >> M> > R> PF ruleset with 1 rule and 1 table. Every few reloads of >> the firewall >> M> > R> and vmstat >> M> > R> -m | grep routetbl shows increased memory usage. >> M> > >> M> > I plugged the easy leak, but there is also a hard one. >> Actually, the >> M> > entire pf_table.c needs a good shake. Right now I am out of >> time for this. >> M> >> M> Is that easy fix >> M> >> M> >> = http://lists.freebsd.org/pipermail/svn-src-head/2014-October/063178.html >>=20 >> Yes, it seems the leak slowed down. >>=20 >> M> Also, is there any work around to this ? I tried a simple set >> of pf >> M> rules with no tables, hoping that was the cause of it, but >> memory grows >> M> with each pf reload. >>=20 >> No workaround available. Can you please file a PR for that? Once I >> have >> time, I will work on this. >>=20 > Remaining leak is not related to pf. > It happens due to rn_detachhead() not properly freeing items inside it = masks tree. > I'll try to fix this soon. I=92ve committed fix in r272385. Can you try it and check if this helps? >>=20 >>=20 >> -- >> Totus tuus, Glebius. >>=20 >>=20 >>=20 >>=20 >> --=20 >> Rumen Telbizov >> Unix Systems Administrator <http://telbizov.com>; >=20 > _______________________________________________ > freebsd-stable@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to = "freebsd-stable-unsubscribe@freebsd.org" >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7AB35136-89AA-48F2-8B0E-1BA3DCD4A6BA>