From owner-svn-src-all@FreeBSD.ORG Sun Jan 15 23:28:07 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 80ACB106564A; Sun, 15 Jan 2012 23:28:07 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 523E18FC0A; Sun, 15 Jan 2012 23:28:07 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) by cyrus.watson.org (Postfix) with ESMTPSA id E84A246B3C; Sun, 15 Jan 2012 18:28:06 -0500 (EST) Received: from John-Baldwins-MacBook-Air.local (c-68-36-150-83.hsd1.nj.comcast.net [68.36.150.83]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 54290B90E; Sun, 15 Jan 2012 18:28:06 -0500 (EST) Message-ID: <4F136109.9050004@FreeBSD.org> Date: Sun, 15 Jan 2012 18:28:09 -0500 From: John Baldwin User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Eitan Adler References: <201201150709.q0F79Iif067938@svn.freebsd.org> In-Reply-To: <201201150709.q0F79Iif067938@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Sun, 15 Jan 2012 18:28:06 -0500 (EST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r230125 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jan 2012 23:28:07 -0000 On 1/15/12 2:09 AM, Eitan Adler wrote: > Author: eadler (ports committer) > Date: Sun Jan 15 07:09:18 2012 > New Revision: 230125 > URL: http://svn.freebsd.org/changeset/base/230125 > > Log: > - Fix undefined behavior when device_get_name is null > - Make error message more informative The in-kernel printf(9) always prints "(null)" for %s when the pointer is NULL, so that wasn't undefined behavior. Printing out the driver name is a useful change, but the "(unknown)" bits are just noise as it isn't clear that "(unknown)" is substantially better than "(null)". -- John Baldwin