Date: Wed, 20 Sep 2006 19:28:42 +1000 From: Peter Jeremy <peterjeremy@optushome.com.au> To: David Malone <dwmalone@maths.tcd.ie> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bge if_bge.c Message-ID: <20060920092842.GD738@turion.vk2pj.dyndns.org> In-Reply-To: <20060920085236.GA58179@walton.maths.tcd.ie> References: <200609182218.k8IMIMUT059300@repoman.freebsd.org> <200609191431.01649.jkim@FreeBSD.org> <20060919190449.GC720@turion.vk2pj.dyndns.org> <200609191535.08184.jkim@FreeBSD.org> <20060920072626.GA738@turion.vk2pj.dyndns.org> <20060920085236.GA58179@walton.maths.tcd.ie>
next in thread | previous in thread | raw e-mail | index | archive | help
--9dgjiU4MmWPVapMU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, 2006-Sep-20 09:52:36 +0100, David Malone wrote: >Putting ethernet specific code in bpf_* feels like a bad idea. Is this any worse than having ethernet specific code in the mbuf header? > It >should be possible to leave hardware assisted VLAN tagging on and >get ether input to reinsert the tag only in cases where there is a >bpf listener. This could still be seen as a layering violation but is probably cleaner. >(It's interesting to note that as ethernet cards introduce more >features it is getting harder for us to tell what we put on the >wire. This probably makes it more critical for bpf to not automatically disable NIC features, otherwise we run the risk of introducing heisenbugs in the network system. >With VLAN tagging we can't trust the VLAN tag. Unlike checksums etc, the kernel must be able to determine the VLAN tag to be able to process the packet. The problem is that it isn't where bpf expects. --=20 Peter Jeremy --9dgjiU4MmWPVapMU Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFEQnK/opHv/APuIcRAhyCAJ9yN5o67IpSlhSKDYpgbG1OTtZ7VgCeOs/n D+1yTJ3XsGY10u8g9CL73Sw= =78// -----END PGP SIGNATURE----- --9dgjiU4MmWPVapMU--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060920092842.GD738>