From owner-svn-src-head@FreeBSD.ORG Tue Sep 28 23:47:22 2010 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E98B1106566B; Tue, 28 Sep 2010 23:47:22 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238]) by mx1.freebsd.org (Postfix) with ESMTP id ABE548FC13; Tue, 28 Sep 2010 23:47:22 +0000 (UTC) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id 7FC8973098; Wed, 29 Sep 2010 01:40:13 +0200 (CEST) Date: Wed, 29 Sep 2010 01:40:13 +0200 From: Luigi Rizzo To: Doug Barton Message-ID: <20100928234013.GA21162@onelab2.iet.unipi.it> References: <201009282246.o8SMkDpg088199@svn.freebsd.org> <4CA2776B.5080905@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CA2776B.5080905@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@FreeBSD.org, Luigi Rizzo , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r213253 - head/sys/netinet/ipfw X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Sep 2010 23:47:23 -0000 On Tue, Sep 28, 2010 at 04:16:59PM -0700, Doug Barton wrote: > On 9/28/2010 3:46 PM, Luigi Rizzo wrote: > >Author: luigi > >Date: Tue Sep 28 22:46:13 2010 > >New Revision: 213253 > >URL: http://svn.freebsd.org/changeset/base/213253 > > > >Log: > > Whitespace changes to reduce diffs wrt the most recent ipfw/dummynet > > code: > > + remove an unused macro, > > + adjust the constants in an enum > > + small whitespace changes > > It's generally a bad idea to mix pure ws changes with functional ones. does unused code count as 'functional' change ? All the changes in this commit are a no-op in FreeBSD-world.