Date: Mon, 29 Jul 2013 08:59:58 -0600 From: Warner Losh <imp@bsdimp.com> To: Hans Petter Selasky <hps@bitfrost.no> Cc: freebsd-wireless@freebsd.org, freebsd-arm <freebsd-arm@freebsd.org> Subject: Re: My WLI-UC-GNM up crash Message-ID: <EBB329CD-460A-4CFB-B3A5-B152A4EC23A9@bsdimp.com> In-Reply-To: <51F4F3E9.9010605@bitfrost.no> References: <cakrd9exvuqeqz=3ntmh7k3e4_6fjw9jph_tpfchujhqhwwbzsg@mail.gmail.com> <1374573600-2351360719.d37ada5f86@bliksem.vehosting.nl> <CAKrd9eXHXmM5_ai0=kV4Sd8U3Fej8FkKp7XXcbppxeBVDHB3Pg@mail.gmail.com> <201307231220.52817.Daan@vitsch.nl> <CAKrd9eXPB2-cAySVSGm-BJHPU9L65fm6rynMpCnNQ-M_B9zMMw@mail.gmail.com> <CAKrd9eWsfgd9EZytBOrxBYyeTaNjPhFO6O5qv-K4ODf9bSDvVw@mail.gmail.com> <CAKrd9eXJH6VQPBTLCayat47Dch8BWmhz3gzYtcSv-6unHb8QMQ@mail.gmail.com> <CAKrd9eW-HUqUTRkaeeC0jaeRjrgRmVhXVfiG0b_0tvgXLuTteg@mail.gmail.com> <CAJ-VmonJcSVs%2Bt0jziUyeH1JMztWchObQmb3NrJ0frVq62nhDg@mail.gmail.com> <CAKrd9eV4-KNwgZGsRq1JRY31V8Dvmt2RLHSn4TKgbHTUxOJFfA@mail.gmail.com> <CAJ-Vmo=pt7Cv9TRmcB%2BFHB_otz-2Jy6HbJgSZ5JfH%2BS3qcf8uA@mail.gmail.com> <51F4F3E9.9010605@bitfrost.no>
next in thread | previous in thread | raw e-mail | index | archive | help
The __aligned(8) likely isn't going to do anything. It says that you are = guaranteeing to the compiler that you'll only ever allocate / cast = pointers to this data type on a 8-byte boundary. __packed might help, = but likely won't because that's for on-wire things and anything thing = that wasn't already not marked packed that should be would already be = broken, but broken giving bad data, not broken segfaulting. __aligned(1) is what you want. But that has other performance = problems... Warner On Jul 28, 2013, at 4:35 AM, Hans Petter Selasky wrote: > Hi, >=20 > Can you try the attached patch? >=20 > --HPS > <radiotap.diff>_______________________________________________ > freebsd-arm@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arm > To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EBB329CD-460A-4CFB-B3A5-B152A4EC23A9>