Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Nov 2003 12:26:12 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
To:        Hajimu UMEMOTO <ume@mahoroba.org>
Cc:        freebsd-ipfw@freebsd.org
Subject:   Re: HEAD ip_fw2 ipsec b0rked
Message-ID:  <Pine.BSF.4.53.0311071214190.653@e0-0.zab2.int.zabbadoz.net>
In-Reply-To: <yge1xskfkta.wl%ume@mahoroba.org>
References:  <Pine.BSF.4.53.0311062137160.653@e0-0.zab2.int.zabbadoz.net> <001501c3a524$8bc40170$0235a8c0@raisa> <yge1xskfkta.wl%ume@mahoroba.org>

Next in thread | Previous in thread | Raw E-Mail | Index | Archive | Help
On Fri, 7 Nov 2003, Hajimu UMEMOTO wrote:

Hi,

> Yes, ipsec_gethist() was obsoleted and replaced by ipsec_getnhist()
> during KAME merge.  Calling ipsec_gethist() in ip_input.c which you
> mentioned was already replaced by ipsec_getnhist().

I had seen this after I got the "nice" panic();

> However, I didn't
> noticed that ipsec_gethist() is called in ip_fw2.c.

Either removing the f() entirely will make people notice it at compile
time that s.th. is missing
or running a find over the src tree will let you find these functions
but giving a panic() isn't that nice ;-))


Perhaps Luigi or you culd review my patch and commit it so that both
problems get fixed at ones because fixing one will not help making the
other work in ip_fw2.c.

-- 
Greetings

Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT
56 69 73 69 74				http://www.zabbadoz.net/



Want to link to this message? Use this URL: <http://docs.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.53.0311071214190.653>