Date: Fri, 26 Jun 2020 14:30:36 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Fernando Apestegu??a <fernape@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r540489 - in head/devel/fhist: . files Message-ID: <20200626143036.GB17169@FreeBSD.org> In-Reply-To: <20200626141926.gvbb6xpbxx7aladv@aching.in.mat.cc> References: <202006261034.05QAYaDe038059@repo.freebsd.org> <20200626124105.GA65385@FreeBSD.org> <20200626132841.kytmjwquonpwkrhr@aching.in.mat.cc> <20200626133811.GA60522@FreeBSD.org> <20200626134752.i4ygenf4cc6we6nk@aching.in.mat.cc> <20200626135912.GA82842@FreeBSD.org> <20200626141926.gvbb6xpbxx7aladv@aching.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 26, 2020 at 04:19:26PM +0200, Mathieu Arnold wrote: > On Fri, Jun 26, 2020 at 01:59:12PM +0000, Alexey Dokuchaev wrote: > > On Fri, Jun 26, 2020 at 03:47:52PM +0200, Mathieu Arnold wrote: > > > Now, the patches in the ports tree need to have a correct and coherent > > > behavior, and fuzzy patching gets it wrong from time to time. This is > > > why range information is not noise, but important metadata that we > > > prefer to be correct all the time. > > > > Well, to your definition of "we". :-) But I get it: you prefer perfect > > patches and noisy commit diffs; I prefer okayish (correctly applicable) > > patches and cleaner commit diffs. > > Well, "we" in that sentence is defined as "ports committers". So you > may want to personnally have patch play russian roulette with the > patches from your ports, but this is not what we want. We want patches > that apply cleanly, Me too. I see no contradiction here. > without patch having to randonly decide where it is going to put the > different hunks. As long as pathes are applied correctly, I prefer to sacrifice purity to get cleaner commit diffs which, as someone frequently working with history, I value a lot more. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200626143036.GB17169>