Date: Mon, 23 Feb 2004 19:56:56 +0200 From: Alexander Motin <mav@alkar.net> To: Max Laier <max@love2party.net> Cc: freebsd-ipfw@freebsd.org Subject: Re: Generating 'Fragment Needed but DF was Set' ICMP & Dummynet Message-ID: <403A3EE8.2000302@alkar.net> In-Reply-To: <200402231807.29317.max@love2party.net> References: <c0soic$1njq$2@pandora.alkar.net.lucky.freebsd.net> <c1d9id$10qf$1@pandora.alkar.net> <200402231807.29317.max@love2party.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Max Laier wrote: > On Monday 23 February 2004 17:25, Alexander Motin wrote: > >>Here are my patches for this problem for FreeBSD 4.8 and 5.2. >>Review them please. > > > Looks good, though you might want to make sure to update statistics > (ipstat.ips_cantfrag++). It is already incremented inside ip_output(). > And maybe lose the type and code vars - you > don't really use them: > - type = ICMP_UNREACH; > - code = ICMP_UNREACH_HOST; > - icmp_error(mcopy, type, code, 0, pkt->ifp); > + icmp_error(mcopy, ICMP_UNREACH, ICMP_UNREACH_HOST, > + 0, pkt->ifp); Of course. As you wish. :) > Also note that this patch will require some work after the MT_TAG remove > http://people.freebsd.org/~mlaier/mt_tag_remove.diff as pkt is freed with > the mbuf. I'll keep it in mind. Yes, but this was only the sample to highlight the problem. :) There also some part of code from ip_forward() about IPSEC MTU can be duplicated. -- Alexander Motin mav@alkar.net ISP "Alkar-Teleport"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?403A3EE8.2000302>