Date: Fri, 12 Dec 2008 06:01:10 +0000 (UTC) From: Sam Leffler <sam@FreeBSD.org> To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r185973 - projects/arpv2_merge_1/sys/net Message-ID: <200812120601.mBC61AOp088302@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: sam Date: Fri Dec 12 06:01:09 2008 New Revision: 185973 URL: http://svn.freebsd.org/changeset/base/185973 Log: o fix comments o gratuitous style change Modified: projects/arpv2_merge_1/sys/net/if_llatbl.c Modified: projects/arpv2_merge_1/sys/net/if_llatbl.c ============================================================================== --- projects/arpv2_merge_1/sys/net/if_llatbl.c Fri Dec 12 06:00:15 2008 (r185972) +++ projects/arpv2_merge_1/sys/net/if_llatbl.c Fri Dec 12 06:01:09 2008 (r185973) @@ -237,10 +237,7 @@ lla_rt_output(struct rt_msghdr *rtm, str return EINVAL; /* XXX not implemented yet */ } - /* - * XXXXXXXX: - * REVISE this approach if possible. - */ + /* XXX linked list may be too expensive */ IFNET_RLOCK(); SLIST_FOREACH(llt, &lltables, llt_link) { if (llt->llt_af == dst->sa_family && @@ -258,9 +255,10 @@ lla_rt_output(struct rt_msghdr *rtm, str IF_AFDATA_UNLOCK(ifp); if (lle != NULL) { if (flags & LLE_CREATE) { - /* qing: if we delay the delete, then if a subsequent - * "arp add" on the same host should look up this entry, - * reset the LLE_DELETED flag, and reset the expiration timer + /* + * If we delay the delete, then a subsequent + * "arp add" should look up this entry, reset the + * LLE_DELETED flag, and reset the expiration timer */ bcopy(LLADDR(dl), &lle->ll_addr, ifp->if_addrlen); lle->la_flags |= LLE_VALID; @@ -273,7 +271,7 @@ lla_rt_output(struct rt_msghdr *rtm, str lle->ln_state = ND6_LLINFO_REACHABLE; #endif /* - * "arp" and "ndp" always sets the (RTF_STATIC | RTF_HOST) flags + * NB: arp and ndp always set (RTF_STATIC | RTF_HOST) */ if (rtm->rtm_rmx.rmx_expire == 0) { @@ -285,8 +283,7 @@ lla_rt_output(struct rt_msghdr *rtm, str LLE_WUNLOCK(lle); #ifdef INET /* gratuious ARP */ - if ((laflags & LLE_PUB) && - dst->sa_family == AF_INET) { + if ((laflags & LLE_PUB) && dst->sa_family == AF_INET) { arprequest(ifp, &((struct sockaddr_in *)dst)->sin_addr, &((struct sockaddr_in *)dst)->sin_addr,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812120601.mBC61AOp088302>