Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 Mar 2004 09:17:22 +0100
From:      "Poul-Henning Kamp" <phk@phk.freebsd.dk>
To:        Marcel Moolenaar <marcel@freebsd.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 48556 for review 
Message-ID:  <39071.1078906642@critter.freebsd.dk>
In-Reply-To: Your message of "Wed, 10 Mar 2004 00:01:00 PST." <200403100801.i2A810eC071863@repoman.freebsd.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <200403100801.i2A810eC071863@repoman.freebsd.org>, Marcel Moolenaar 
writes:
>http://perforce.freebsd.org/chv.cgi?CH=48556
>
>Change 48556 by marcel@marcel_nfs on 2004/03/10 00:00:12
>
>	Revamp the kernel debugger support. There's a non-optional
>	front-end which constitutes the interface. Behind it are
>	the debugger back-ends. The back-ends, currently only DDB
>	and GDB, are optional and selectable at runtime.
>	
>	This commit replaces Debugger() and backtrace() references
>	with kdb_enter() and kdb_backtrace() respectively. Where
>	appropriate, <sys/kdb.h> is included.
>	
>	Note that most #ifdef DDB instances have to be replaced
>	with #ifdef DEBUG, because DDB is specific to a single
>	back-end, not to having debugging support in general. A
>	new option, GDB, has been added to add support for gdb.
>	This has to be worked-out still.

#ifdef DEBUG is a singulary bad choice since much code have private
use of that macro.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?39071.1078906642>