From owner-p4-projects@FreeBSD.ORG  Wed Mar 10 00:17:24 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 8562916A4D1; Wed, 10 Mar 2004 00:17:24 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5F69016A4CE; Wed, 10 Mar 2004 00:17:24 -0800 (PST)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9715643D3F; Wed, 10 Mar 2004 00:17:23 -0800 (PST)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i2A8HMHA039072;
	Wed, 10 Mar 2004 09:17:22 +0100 (CET)
	(envelope-from phk@phk.freebsd.dk)
To: Marcel Moolenaar <marcel@freebsd.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Wed, 10 Mar 2004 00:01:00 PST."
             <200403100801.i2A810eC071863@repoman.freebsd.org> 
Date: Wed, 10 Mar 2004 09:17:22 +0100
Message-ID: <39071.1078906642@critter.freebsd.dk>
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 48556 for review 
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Mar 2004 08:17:25 -0000

In message <200403100801.i2A810eC071863@repoman.freebsd.org>, Marcel Moolenaar 
writes:
>http://perforce.freebsd.org/chv.cgi?CH=48556
>
>Change 48556 by marcel@marcel_nfs on 2004/03/10 00:00:12
>
>	Revamp the kernel debugger support. There's a non-optional
>	front-end which constitutes the interface. Behind it are
>	the debugger back-ends. The back-ends, currently only DDB
>	and GDB, are optional and selectable at runtime.
>	
>	This commit replaces Debugger() and backtrace() references
>	with kdb_enter() and kdb_backtrace() respectively. Where
>	appropriate, <sys/kdb.h> is included.
>	
>	Note that most #ifdef DDB instances have to be replaced
>	with #ifdef DEBUG, because DDB is specific to a single
>	back-end, not to having debugging support in general. A
>	new option, GDB, has been added to add support for gdb.
>	This has to be worked-out still.

#ifdef DEBUG is a singulary bad choice since much code have private
use of that macro.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.