From owner-svn-src-all@freebsd.org Sat Mar 4 22:23:33 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 08F32CF9A6C; Sat, 4 Mar 2017 22:23:33 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C91C41B4B; Sat, 4 Mar 2017 22:23:32 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x241.google.com with SMTP id j5so13455119pfb.3; Sat, 04 Mar 2017 14:23:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=DAOiFSgnK1Ch/TdpwrhvwWUdenFvg0/4bwgOg3qkOWg=; b=HBSgnKIx7U7WyXCwja8HlQw+WPsnAuAlsfsregTjQTOfBrygkSYAovNcDEgMFUFJb9 bu/Tv6yRRCrRE1NtZb9DiE4L4vqWiRU32qZSMfVDxPNCVjppqJmVSMCziHt9utbFZZ8z mKg4LNQ3w+yezgEj/fziscHDI0gfNGkLMcpeEJZxF/vl+z5CoUCGxkjBIFQ0o70+n7JM N30s6EeNr1AQEe6ialcR3MGL909vcYdSM/ZYZpRMO+WrYrAm0owBfXDz9SYAEjTQZf2h fvSKHKBTS6y09qa3W3hP0JNWj0AEZLphUT1MSB6dCSoJyS905gn2RUdCqQO77gvDA6xm db6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=DAOiFSgnK1Ch/TdpwrhvwWUdenFvg0/4bwgOg3qkOWg=; b=qmVsBMOp2XBCgYGqhwiggGG9eQMeSMEmWVKCPLszVidSqEeE+dcfwmr6+q9DlLZZBM oydZaf7yStXeMZjYdJPGdr8wtfRfWLIvUlO4hVIr6BG6Nkj/ooxCAqUlk1arxhea10cK iRyeZ7Isrd18kulklkzgFczk/qB1X6wEHHlDAFCyMBiZscw7ylOoV4/eY5x3AOm16Qng 45uPVg+l4faBnfX6WVzKhAVYi3IoYv+iE/95YkqbBXN9+L/UjMTUiyU5VXzccIBOJJXQ 4lfsNLTyHqB3J8tys2+gRlKRg+iDXmcF9+r9pXI7PGNZQ8MkPBPYyAwyJDiqsunUDP39 wwjA== X-Gm-Message-State: AMke39nzzMrzl1M9ZU/qRYXO7LmXm3E83Qb/kWc9clUyhSK3kRF5Omu66snXbAVCuAGfIQ== X-Received: by 10.98.60.199 with SMTP id b68mr12143797pfk.102.1488666212319; Sat, 04 Mar 2017 14:23:32 -0800 (PST) Received: from ?IPv6:2607:fb90:277e:24bf:f967:c793:b61:5112? ([2607:fb90:277e:24bf:f967:c793:b61:5112]) by smtp.gmail.com with ESMTPSA id d3sm30918848pfc.51.2017.03.04.14.23.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Mar 2017 14:23:31 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r314657 - in head/kerberos5: . lib/libgssapi_krb5 lib/libgssapi_ntlm lib/libgssapi_spnego lib/libhdb lib/libkafs5 lib/libkrb5 libexec/hprop libexec/kpasswdd tools/asn1_compile tools/slc From: Ngie Cooper X-Mailer: iPhone Mail (14D27) In-Reply-To: Date: Sat, 4 Mar 2017 14:23:30 -0800 Cc: Bryan Drewery , rgrimes@freebsd.org, Ngie Cooper , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <201703042020.v24KKD5N078654@pdx.rh.CN85.dnsmgr.net> <7ed86250-8f8e-d034-0959-dc46e8973583@FreeBSD.org> To: Warner Losh X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Mar 2017 22:23:33 -0000 > On Mar 4, 2017, at 13:43, Warner Losh wrote: >=20 >> On Sat, Mar 4, 2017 at 1:25 PM, Bryan Drewery wrot= e: >>> On 3/4/2017 12:20 PM, Rodney W. Grimes wrote: >>> -- Start of PGP signed section. >>> [ Charset windows-1252 unsupported, converting... ] >>>>> On 3/4/2017 7:34 AM, Rodney W. Grimes wrote: >>>>> What is ${.CURDIR:H:H} ????? Yes that seems to work but now we are ob= scuring >>>>> ../.. into makefile syntax magic, probably not a grand idea. >>>> It just trims off the last directory component. This both reduces >>>> namecache lookups, lessens the amount of data in a log, and makes >>>> debugging a log simpler by not having a crazy path like: >>>> /home/bdrewery/big/git/buildserver/sys/modules/usb/template/../../../de= v/usb/template/usb_template.c >>>>=20 >>>> It's far simpler to understand and work with: >>>> /home/bdrewery/big/git/buildserver/sys/dev/usb/template/usb_template.c >>>>=20 >>>> The only downside is it is slightly more obscure in a Makefile, but onc= e >>>> you know what :H is then it's not a problem. This is why SRCTOP is eve= n >>>> better than this as it is far more clear than even :H and avoids the >>>> ../../ problems. >>> Lets do one or the other, but not both ${SRCTOP} and :H:H:H. It appears= >>> that we now have a mix and mashed up some one way others the other. >>=20 >> That I can agree with. I would prefer to standardize on SRCTOP as :H is >> too obscure without learning about make details. >=20 > :H is insane in 90% of the cases I've seen it used. Let's roll with > SRCTOP everywhere we can. That's safer from directory motion anyway... Ok, I have 3 votes for SRCTOP, so I'll implement the remaining change using S= RCTOP (for usr.bin), and reimplement the previous changes using SRCTOP. Thank you all for the input, -Ngie=