From owner-freebsd-bugs@FreeBSD.ORG  Sun Aug  3 19:00:13 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 200D2106575B
	for <freebsd-bugs@hub.freebsd.org>;
	Sun,  3 Aug 2008 19:00:13 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 805948FC0C
	for <freebsd-bugs@hub.freebsd.org>;
	Sun,  3 Aug 2008 19:00:06 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m73J06FL060634
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 3 Aug 2008 19:00:06 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m73J06t2060633;
	Sun, 3 Aug 2008 19:00:06 GMT (envelope-from gnats)
Resent-Date: Sun, 3 Aug 2008 19:00:06 GMT
Resent-Message-Id: <200808031900.m73J06t2060633@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Mateusz Guzik <mjguzik@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8BB83106564A
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sun,  3 Aug 2008 18:55:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 7A5E98FC08
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sun,  3 Aug 2008 18:55:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m73Itg9X010088
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 3 Aug 2008 18:55:42 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m73Itgml010074;
	Sun, 3 Aug 2008 18:55:42 GMT (envelope-from nobody)
Message-Id: <200808031855.m73Itgml010074@www.freebsd.org>
Date: Sun, 3 Aug 2008 18:55:42 GMT
From: Mateusz Guzik <mjguzik@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: kern/126223: [patch] Unused `error' variable in kthread_add()
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Aug 2008 19:00:13 -0000


>Number:         126223
>Category:       kern
>Synopsis:       [patch] Unused `error' variable in kthread_add()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 03 19:00:06 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Mateusz Guzik
>Release:        8.0-CURRENT
>Organization:
>Environment:
FreeBSD eternal 8.0-CURRENT FreeBSD 8.0-CURRENT #24: Wed Jul 23 01:21:38 CEST 2008     f@eternal:/usr/obj/usr/src/sys/ETERNAL  i386

>Description:
Variable `error' is declared and set to 0, but not used later.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- sys/kern/kern_kthread.c.orig	2008-08-03 20:35:18.000000000 +0200
+++ sys/kern/kern_kthread.c	2008-08-03 20:35:33.000000000 +0200
@@ -241,16 +241,14 @@
 kthread_add(void (*func)(void *), void *arg, struct proc *p,
     struct thread **newtdp, int flags, int pages, const char *fmt, ...)
 {
 	va_list ap;
 	struct thread *newtd, *oldtd;
-	int error;
 
 	if (!proc0.p_stats)
 		panic("kthread_add called too soon");
 
-	error = 0;
 	/* If no process supplied, put it on proc0 */
 	if (p == NULL) {
 		p = &proc0;
 		oldtd = &thread0;
 	} else {


>Release-Note:
>Audit-Trail:
>Unformatted: