From owner-freebsd-hackers Mon Sep 23 8: 5:41 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D90537B401 for ; Mon, 23 Sep 2002 08:05:40 -0700 (PDT) Received: from mail.thundernet.cz (mail.thundernet.cz [62.77.87.114]) by mx1.FreeBSD.org (Postfix) with SMTP id 688DA43E65 for ; Mon, 23 Sep 2002 08:05:39 -0700 (PDT) (envelope-from neuhauser@bellavista.cz) Received: (qmail 12355 invoked from network); 23 Sep 2002 15:05:37 -0000 Received: from unknown (HELO freepuppy.bellavista.cz) (62.168.44.50) by mail.thundernet.cz with SMTP; 23 Sep 2002 15:05:37 -0000 Received: by freepuppy.bellavista.cz (Postfix, from userid 1001) id 18F762FDAB2; Mon, 23 Sep 2002 17:05:37 +0200 (CEST) Date: Mon, 23 Sep 2002 17:05:36 +0200 From: Roman Neuhauser To: freebsd-hackers@freebsd.org Subject: periodic(8)-produced diffs Message-ID: <20020923150536.GB30361@freepuppy.bellavista.cz> Mail-Followup-To: freebsd-hackers@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.1i Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG [repost from questions@; no replies received since 2002-09-17] Hi there, various /etc/periodic scripts mail root diffs of a few config files etc. grep on my (quite fresh) STABLE box shows that except for /etc/periodic/daily/210.backup-aliases, all the diff invocations use the old format. I have two issues with this: first, all the diffs should be in the same format, and second, root should be able to select their preferred format in /etc/periodic.conf (yes, i have difficulty reading anything but unified diffs). Now, before I go and produce a patch, would such a change be actually welcome, or am I going to get shot down? And, what would the preferred interface be? Most of periodic.conf knobs are bools, but I'm not sure diff_{context,traditional,unified}_format="{YES,NO}" is better than diff_format="{context,traditional,unified}" What do you think? -- begin 666 nonexistent.vbs FreeBSD 4.7-RC 5:03PM up 6 days, 18 mins, 22 users, load averages: 0.03, 0.11, 0.08 end To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message