From owner-svn-src-all@freebsd.org Sat Mar 4 22:32:17 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 52A7CCF9C8D; Sat, 4 Mar 2017 22:32:17 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B75D110BD; Sat, 4 Mar 2017 22:32:15 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v24MW9ok079230; Sat, 4 Mar 2017 14:32:09 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v24MW9jt079229; Sat, 4 Mar 2017 14:32:09 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201703042232.v24MW9jt079229@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r314657 - in head/kerberos5: . lib/libgssapi_krb5 lib/libgssapi_ntlm lib/libgssapi_spnego lib/libhdb lib/libkafs5 lib/libkrb5 libexec/hprop libexec/kpasswdd tools/asn1_compile tools/slc In-Reply-To: To: Ngie Cooper Date: Sat, 4 Mar 2017 14:32:08 -0800 (PST) CC: Warner Losh , Bryan Drewery , rgrimes@freebsd.org, Ngie Cooper , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Mar 2017 22:32:17 -0000 > > > On Mar 4, 2017, at 13:43, Warner Losh wrote: > > > >> On Sat, Mar 4, 2017 at 1:25 PM, Bryan Drewery wrote: > >>> On 3/4/2017 12:20 PM, Rodney W. Grimes wrote: > >>> -- Start of PGP signed section. > >>> [ Charset windows-1252 unsupported, converting... ] > >>>>> On 3/4/2017 7:34 AM, Rodney W. Grimes wrote: > >>>>> What is ${.CURDIR:H:H} ????? Yes that seems to work but now we are obscuring > >>>>> ../.. into makefile syntax magic, probably not a grand idea. > >>>> It just trims off the last directory component. This both reduces > >>>> namecache lookups, lessens the amount of data in a log, and makes > >>>> debugging a log simpler by not having a crazy path like: > >>>> /home/bdrewery/big/git/buildserver/sys/modules/usb/template/../../../dev/usb/template/usb_template.c > >>>> > >>>> It's far simpler to understand and work with: > >>>> /home/bdrewery/big/git/buildserver/sys/dev/usb/template/usb_template.c > >>>> > >>>> The only downside is it is slightly more obscure in a Makefile, but once > >>>> you know what :H is then it's not a problem. This is why SRCTOP is even > >>>> better than this as it is far more clear than even :H and avoids the > >>>> ../../ problems. > >>> Lets do one or the other, but not both ${SRCTOP} and :H:H:H. It appears > >>> that we now have a mix and mashed up some one way others the other. > >> > >> That I can agree with. I would prefer to standardize on SRCTOP as :H is > >> too obscure without learning about make details. > > > > :H is insane in 90% of the cases I've seen it used. Let's roll with > > SRCTOP everywhere we can. That's safer from directory motion anyway... > > Ok, I have 3 votes for SRCTOP, so I'll implement the remaining change using SRCTOP (for usr.bin), and reimplement the previous changes using SRCTOP. And that some how over rides the 3 votes for not doing any of these changes? Slow down please. We dont need a bike shed, but I think we need a clear target and a consense larger than 3+ 3- and less than a 6 hour wall clock of discussion. It would also be best if it was this change and only this change committed in very large (preferably about 20) commits. -- Rod Grimes rgrimes@freebsd.org