Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Oct 2010 02:42:26 -0700
From:      Stanislav Sedov <stas@FreeBSD.org>
To:        Steve Wills <swills@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/devel Makefile ports/devel/rubygem-pkg-config Makefile distinfo pkg-descr
Message-ID:  <20101012024226.2dc802a8.stas@FreeBSD.org>
In-Reply-To: <201010120311.o9C3BhVW079967@repoman.freebsd.org>
References:  <201010120311.o9C3BhVW079967@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Tue__12_Oct_2010_02_42_26_-0700_tUu.MOqacs3MzLwr
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, 12 Oct 2010 03:11:43 +0000 (UTC)
Steve Wills <swills@FreeBSD.org> mentioned:

> swills      2010-10-12 03:11:43 UTC
>=20
>   FreeBSD ports repository
>=20
>   Modified files:
>     devel                Makefile=20
>   Added files:
>     devel/rubygem-pkg-config Makefile distinfo pkg-descr=20
>   Log:
>   - New port, a ruby gem for accessing pkg-config
>  =20
>   Submitted by:   me (swills)
>   Approved by:    pgollucci (mentor)

Thanks for this port!
Some things I noticed:
1. The WWW link points to the gem's page, not the homepage.
   The real homepage of the project is http://github.com/rcairo/pkg-config
2. It doesn't seem to depend on hoe, where this dependency come from?
3. We usually don't use hypens in the portname, and portlint wanrs
   about this afaik.  It'd be better to name the port rubygem-pkgconfig
4. We usually prefer static pkg-plists instead of dynamic ones, especially
   in simple ones.  Although it's totally a maintainer consideration,
   it is usually nice to have a plist you can search in with grep.
5. Although also a maintainer's choice I find it better to have
   non-gem versions of the libraries when they're available (like in
   this case).  The reasons are that the non-gem version can be used
   both in application that supports gems and the one that doesn't,
   and it is possible to patch the port when it is needed.  If in some
   time in future you will need to patch the contents on the port, it
   is impossible to do with gems.

--=20
Stanislav Sedov
ST4096-RIPE

--Signature=_Tue__12_Oct_2010_02_42_26_-0700_tUu.MOqacs3MzLwr
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----

iQIcBAEBAgAGBQJMtC2HAAoJEL8lojEJL9nwU30P/iTB+bbbHh4GTy7eorvm1coN
RdUj/f0W6BcJJSd8b7rTSaq3SAhj0KRjQc2JARVH9C+6mB+l5g70E55MhHGhlnwK
9X5639WqLIxDnmv93u+yMqYnxrzcpXlN4W3P1s+PqyFfudTZQt7pXbjXt+kvszm0
UiOZH1gPNkSaw/CdR6z/68Vl0JaCOtHjcou3wIzAv94DvqulVEQdRVfZsenTD8Bn
YNuTXEZ3u3LpbPSVMFLvYU3dZ+IORqNtOsWkQY6QpVjZ5ba2uOvKYwpgoUVCrLBC
t7hPEeyb9E0IB+ciCfj8dnDvR5v+7cB2C67XUPCH7D3bWNQML5ZUOVR5kJIVaQm0
B+99LWLB8Wt8yRSn91zY3jBBU4pphSLAq7x1v4so8fV3bQTkp3hIh+NXs/AlUDST
YE5+D07t5v5yr7SePjvMYKZJUzzMpkQVLqeD9Qtv76fPw1WLxatE6ANwsuzF+Yog
RtLFoTsQShndg5XcfsCgEdpNPejafb1iGSbbB8lOjPFzZSazFyh2pAkg/6gXXdZ3
TeluopbYnGsl5OhuYQqy73jvZ2vqUBL/EXBR7nQdmUfT8g8TGmoldrqJqJNPBP1F
4pdrBISNd8FKeCydzoptMsXi/rSKP0zhUPUnAksi09qR3tpHN2io0s0CYlIOcXms
HUxTDCwRxgWDz9wICOs3
=BmzQ
-----END PGP SIGNATURE-----

--Signature=_Tue__12_Oct_2010_02_42_26_-0700_tUu.MOqacs3MzLwr--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101012024226.2dc802a8.stas>