From owner-svn-src-head@FreeBSD.ORG Tue Sep 29 14:54:49 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DA06A106566B; Tue, 29 Sep 2009 14:54:49 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from smtp.timeweb.ru (smtp.timeweb.ru [217.170.79.85]) by mx1.freebsd.org (Postfix) with ESMTP id 9141D8FC1B; Tue, 29 Sep 2009 14:54:49 +0000 (UTC) Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.69) (envelope-from ) id 1Mshpm-0000zO-5f; Tue, 29 Sep 2009 22:53:58 +0400 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id F3739B84D; Tue, 29 Sep 2009 18:54:46 +0400 (MSD) Received: by hades.panopticon (Postfix, from userid 1000) id 12B96B849; Tue, 29 Sep 2009 18:54:47 +0400 (MSD) Date: Tue, 29 Sep 2009 18:54:47 +0400 From: Dmitry Marakasov To: John Baldwin Message-ID: <20090929145447.GA82539@hades.panopticon> References: <200909282352.n8SNql1n069970@svn.freebsd.org> <200909290749.08764.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <200909290749.08764.jhb@freebsd.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar , src-committers@freebsd.org Subject: Re: svn commit: r197608 - head/sys/geom/part X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2009 14:54:50 -0000 * John Baldwin (jhb@freebsd.org) wrote: > Why do you check for zeros at all? AFAIK, the only real check is for AA55 at > the end of the sector (and having an MBR or other Extended MBR partition > entry point at the sector in question). The '96' thing seems rather > arbitrary in the code, and I think the zero's check is overly restrictive. Seconded. I've seen a report of geom_part_ebr unable to detect partitions which were actually there. Will inquiry the reporter if this change solved the problem. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru