From owner-freebsd-bugs@FreeBSD.ORG  Mon Oct 25 20:40:09 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DEAE316A4D0; Mon, 25 Oct 2004 20:40:09 +0000 (GMT)
Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1F76F43D39; Mon, 25 Oct 2004 20:40:09 +0000 (GMT)
	(envelope-from bzeeb-lists@lists.zabbadoz.net)
Received: from transport.cksoft.de (localhost [127.0.0.1])
	by transport.cksoft.de (Postfix) with ESMTP
	id 1DFBF1FF9AB; Mon, 25 Oct 2004 22:40:07 +0200 (CEST)
Received: by transport.cksoft.de (Postfix, from userid 66)
	id 418261FF9A8; Mon, 25 Oct 2004 22:40:05 +0200 (CEST)
Received: by mail.int.zabbadoz.net (Postfix, from userid 1060)
	id EE59815604; Mon, 25 Oct 2004 20:36:52 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by mail.int.zabbadoz.net (Postfix) with ESMTP
	id E3A58155ED; Mon, 25 Oct 2004 20:36:52 +0000 (UTC)
Date: Mon, 25 Oct 2004 20:36:52 +0000 (UTC)
From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
X-X-Sender: bz@e0-0.zab2.int.zabbadoz.net
To: Arjan de Vet <devet@devet.org>
In-Reply-To: <20041023121049.A20631938D@adv.devet.org>
Message-ID: <Pine.BSF.4.53.0410252033490.38216@e0-0.zab2.int.zabbadoz.net>
References: <20041023121049.A20631938D@adv.devet.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de
cc: freebsd-bugs@FreeBSD.org
cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: 
	Re: kern/73038: if_sk.c seems to need IFF_NEEDSGIANT on 5.3-BETA/RC1
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Oct 2004 20:40:10 -0000

On Sat, 23 Oct 2004, Arjan de Vet wrote:

> >Fix:
>
> Index: if_sk.c
> ===================================================================
> RCS file: /home/freebsd/CVS/src/sys/pci/if_sk.c,v
> retrieving revision 1.83.2.2
> diff -u -r1.83.2.2 if_sk.c
> --- if_sk.c	25 Aug 2004 21:19:06 -0000	1.83.2.2
> +++ if_sk.c	23 Oct 2004 11:47:50 -0000
> @@ -1375,7 +1375,7 @@
>  	ifp->if_softc = sc_if;
>  	if_initname(ifp, device_get_name(dev), device_get_unit(dev));
>  	ifp->if_mtu = ETHERMTU;
> -	ifp->if_flags = IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST;
> +	ifp->if_flags = IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST | IFF_NEEDSGIANT;
>  	ifp->if_ioctl = sk_ioctl;
>  	ifp->if_start = sk_start;
>  	ifp->if_watchdog = sk_watchdog;

does not help with for the tx path starvation problem here on
my amd64 with 5.3.

-- 
Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT