From owner-p4-projects@FreeBSD.ORG Wed Mar 10 08:15:47 2004 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 5A96F16A4D0; Wed, 10 Mar 2004 08:15:47 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3273E16A4CE for ; Wed, 10 Mar 2004 08:15:47 -0800 (PST) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id D0E3243D1D for ; Wed, 10 Mar 2004 08:15:46 -0800 (PST) (envelope-from marcel@xcllnt.net) Received: from dhcp01.pn.xcllnt.net (dhcp01.pn.xcllnt.net [192.168.4.201]) by ns1.xcllnt.net (8.12.11/8.12.11) with ESMTP id i2AGFkpn016083; Wed, 10 Mar 2004 08:15:46 -0800 (PST) (envelope-from marcel@piii.pn.xcllnt.net) Received: from dhcp01.pn.xcllnt.net (localhost [127.0.0.1]) i2AGFkrH036043; Wed, 10 Mar 2004 08:15:46 -0800 (PST) (envelope-from marcel@dhcp01.pn.xcllnt.net) Received: (from marcel@localhost) by dhcp01.pn.xcllnt.net (8.12.11/8.12.11/Submit) id i2AGFcVm036042; Wed, 10 Mar 2004 08:15:38 -0800 (PST) (envelope-from marcel) Date: Wed, 10 Mar 2004 08:15:37 -0800 From: Marcel Moolenaar To: Poul-Henning Kamp Message-ID: <20040310161537.GA36028@dhcp01.pn.xcllnt.net> References: <200403100801.i2A810eC071863@repoman.freebsd.org> <39071.1078906642@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39071.1078906642@critter.freebsd.dk> User-Agent: Mutt/1.4.2.1i cc: Perforce Change Reviews Subject: Re: PERFORCE change 48556 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Mar 2004 16:15:47 -0000 On Wed, Mar 10, 2004 at 09:17:22AM +0100, Poul-Henning Kamp wrote: > In message <200403100801.i2A810eC071863@repoman.freebsd.org>, Marcel Moolenaar > > Note that most #ifdef DDB instances have to be replaced > > with #ifdef DEBUG, because DDB is specific to a single > > back-end, not to having debugging support in general. A > > new option, GDB, has been added to add support for gdb. > > This has to be worked-out still. > > #ifdef DEBUG is a singulary bad choice since much code have private > use of that macro. The point of using a define is to be able to get rid of the debugger calls in production systems. It doesn't matter if DEBUG has private meaning as long as it relates to having debugging code. Other than that, anything else is fine too, as long as it's not DDB. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net