From owner-freebsd-current Sun Apr 23 12:10: 5 2000 Delivered-To: freebsd-current@freebsd.org Received: from gndrsh.dnsmgr.net (GndRsh.dnsmgr.net [198.145.92.4]) by hub.freebsd.org (Postfix) with ESMTP id B124F37BA74; Sun, 23 Apr 2000 12:09:58 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.9.3/8.9.3) id MAA09128; Sun, 23 Apr 2000 12:09:36 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <200004231909.MAA09128@gndrsh.dnsmgr.net> Subject: Re: Linux emulation scripting fix to be committed to 5.x and 4.x wednesday In-Reply-To: <200004231855.LAA63309@apollo.backplane.com> from Matthew Dillon at "Apr 23, 2000 11:55:08 am" To: dillon@apollo.backplane.com (Matthew Dillon) Date: Sun, 23 Apr 2000 12:09:36 -0700 (PDT) Cc: phk@critter.freebsd.dk (Poul-Henning Kamp), freebsd-current@FreeBSD.ORG, freebsd-stable@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > There's another good reason to MFC the linux patch on wednesday... > that is, to do it at the same time the SMP cleanup is MFC'd, and that > is because both patch sets require the linux kernel module to be > recompiled and I'd rather not force people to do that twice. > > The SMP patchset, in fact, requires that all kernel modules be > recompiled due to the locks that were removed from the spl*() macros. In that case I have a strong objection to the SMP patchset being merged to 4.0. I have kernel modules in object format only that are working now, which this would break :-(. Either way, nothing ever should me an immediate MFC, even a blantant security hole should not be MFC'ed immediately, code needs to be tested, and some other person might find a few niglets that need cleaned up before you MFC it. Who knows, you might even break the system, and an immediate MFC would break both at once. Never, ever should anything be immediatly merged. IMHO, no even spelling fixes, as I have seen those done wrong, patched, and MFC'ed again. -- Rod Grimes - KD7CAX @ CN85sl - (RWG25) rgrimes@gndrsh.dnsmgr.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message