From owner-svn-src-head@freebsd.org Tue Jul 16 19:44:58 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 04E1DB8E66 for ; Tue, 16 Jul 2019 19:44:58 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A97B171A54 for ; Tue, 16 Jul 2019 19:44:56 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-vs1-xe44.google.com with SMTP id m8so14807150vsj.0 for ; Tue, 16 Jul 2019 12:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xhq4HqtWpYVviAoGYvVSrVPQr2hi1ZYDm133K18hx3A=; b=dUPTzKYM63mIHT2C8+dqLCGHOrJ0nahuycKciDqnIQx5O9h/no9nB+VNgXDcYg5ilk ipUg5WxakPrO2cxap16IriowzbhYptRaNCXI7AoxVAT7lHyGSp241kXOAU2g5rL4ju7c 0sKnvuDr8G1lGFoVT1+MjW/657V8Zb1us089QWiTHqOuCoou4SbnsPFD3d0Jzmwow9b6 9ASKLO29gM5yJpPmS/VOxibJ8X8VuXsV3BZaDxOxmLFYUjq+yxA/OczxlFT29dMhoubt aXdeEWfy2FnUETEsfgaTDYC8o1gbWFZLeEqj/ikUVPm5WfdfcmIy5MCzWpCAOCizhP4t I/jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xhq4HqtWpYVviAoGYvVSrVPQr2hi1ZYDm133K18hx3A=; b=n9yn3b4zP3FZhSw5E7Tu0Yx7B6kTCGuW6NdOyewOrYLAPQD1v4oqq9GzCEAmNEM8mM eAd1eEUpNgbBEc5v23h4r5S+VTuvPJ0wGB5xDXym6No0hQcnPC0HDUo2kiNCL/jwXKfI Pi37HkSlpU9gnUgaY7BSJpMuTeF4764595DmX6hFxonIVLRZHcPb1IIwN8QElEuaWXVc JQ8Rw67GOJEgglyqY96A9fnwq4NteL/cpm0HChrsuctASVzwlvmQBq2EvVsEjL4JNA9c 3cqAD66z5UMZrorLrt583oUCYzLr95DCvMBKpjP4IUQuG14R3W+/UMF9AznGMAsYV2qx 6XTw== X-Gm-Message-State: APjAAAWvvxRzmAalgA7plbDhmspntzqFLyXXJ8VQzsPqLaO+OFlT6WKB HejQFG7YsO1lRdUaa70Uz9XFBA== X-Google-Smtp-Source: APXvYqwwvvm13oyddgEpD3LhmmIMeXcO+ytXKL+eR72+pixkMwBwwGLb5VkqRBcyd7GqOHBi0OBoZQ== X-Received: by 2002:a67:ab0d:: with SMTP id u13mr21851198vse.145.1563306296112; Tue, 16 Jul 2019 12:44:56 -0700 (PDT) Received: from mutt-hbsd ([151.196.118.239]) by smtp.gmail.com with ESMTPSA id n129sm4392315vsc.18.2019.07.16.12.44.55 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 16 Jul 2019 12:44:55 -0700 (PDT) Date: Tue, 16 Jul 2019 15:44:54 -0400 From: Shawn Webb To: Brooks Davis Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r350049 - head/contrib/amd/amd Message-ID: <20190716194454.odytcdjtlduliz6l@mutt-hbsd> References: <201907161603.x6GG38oZ020228@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4sd5ly7yvjmy2vpg" Content-Disposition: inline In-Reply-To: <201907161603.x6GG38oZ020228@repo.freebsd.org> X-Operating-System: FreeBSD mutt-hbsd 13.0-CURRENT-HBSD FreeBSD 13.0-CURRENT-HBSD X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0xFF2E67A277F8E1FA User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: A97B171A54 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b=dUPTzKYM; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2607:f8b0:4864:20::e44 as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org X-Spamd-Result: default: False [-5.87 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[hardenedbsd.org:+]; MX_GOOD(-0.01)[cached: alt1.aspmx.l.google.com]; NEURAL_HAM_SHORT(-0.99)[-0.988,0]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; IP_SCORE(-0.78)[ip: (1.79), ipnet: 2607:f8b0::/32(-3.17), asn: 15169(-2.45), country: US(-0.06)]; RECEIVED_SPAMHAUS_PBL(0.00)[239.118.196.151.zen.spamhaus.org : 127.0.0.10]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org:s=google]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[hardenedbsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[4.4.e.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; MID_RHS_NOT_FQDN(0.50)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 19:44:58 -0000 --4sd5ly7yvjmy2vpg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 16, 2019 at 04:03:08PM +0000, Brooks Davis wrote: > Author: brooks > Date: Tue Jul 16 16:03:08 2019 > New Revision: 350049 > URL: https://svnweb.freebsd.org/changeset/base/350049 >=20 > Log: > Fix two mismatches between function declaration and definition. > =20 > In both cases, function pointer arguments were inconsistently declared > and the result worked because of C's odd rules around function pointer > (de)references. With a stricter compiler these fail to compile. And, with CFI applied to the kernel, would cause a panic. :) Good catch and thanks for the great work! --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 --4sd5ly7yvjmy2vpg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl0uKTEACgkQ/y5nonf4 4fpY3xAAqKnAegT4e8E2L6pUei14CJwB6Od2xAgXmGf/IiAxsqVRRTuV2XMJMBHc 7cpVlr7pbaOijABDKXvDShOweS4ZobME1nhklLuz88dpr+CvqqZg3Rg5W9sSJFy7 uCk2Gcs66pGipMZr1yXk8ZhgmucmZRWywJHqL0cvsWamW/KF68D+Kk7+XhJZ8sJW /TneAyXBZ4JaFCkbktPXanoNliIcd/YqHDj7s1Y9SdEjc8n3+wscq4s9FkdONlBD /ysPwp31X5RZdTD6xr7g0qvwSRsGygZMXYQzSRfJNGVqaQmhllzdRDTQhfzcL6FU zzPLuFFddiv7Jzlq77t12Vctl2qLaDcUOPsN7j/XMEgud41086sXtN8OWMX6F3Ay fpV4OtmBnpZejcCLjy2/Vgkoy1tT3jou5xSj2yZW94ttYHyh+DpdgZyUkL6cMlrd QFg1uuJsHmTICaCEYickH7qXzVOqsQTjrVZUeQZquNLW7+Fn4z6TjXDVb2tMfob7 L8MKK5g4aLm7CKJ79VJqVJ3ITnD+rKio74sxXxuHxqrW0cXI1ntd430jRu0adZIN 85I2yMxzWEFFMCFmc31xIEgKj8luBMsrY3kq9vbZSWI4cAd9aK97Z49p8aDOPZ33 GEPBv4D24Jr0mfYWcZco80uViV+q/bv64H8I3i1ikjezzZZ0LL0= =aQZI -----END PGP SIGNATURE----- --4sd5ly7yvjmy2vpg--