Date: Tue, 23 Apr 2013 11:59:58 -0500 From: Brooks Davis <brooks@freebsd.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: arch@freebsd.org, "Simon J. Gerraty" <sjg@juniper.net>, toolchain@freebsd.org Subject: Re: [RFC] [Optionally] build tests with buildworld Message-ID: <20130423165958.GA91607@lor.one-eyed-alien.net> In-Reply-To: <CAGHfRMCTRM4sFS09jLp3DegJ5U0xujHmaw0YuAW1JTOuTqHGaw@mail.gmail.com> References: <CAGHfRMCTRM4sFS09jLp3DegJ5U0xujHmaw0YuAW1JTOuTqHGaw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 19, 2013 at 11:17:50PM -0700, Garrett Cooper wrote: > Hi arch@ and toolchain@, > One of the items that I'm proposing be added to Makefile.inc1 in > order to make building and installing tests on CURRENT (ATF and > otherwise) is a build knob called TESTS_WITH_WORLD (the name can be > modified), which allows me to build and install various tests on my > git branch like the example ATF tests I produced, pjdfstest, some of > the prove tests from tools/regression, etc (there are other > outstanding changes, but this was the key one that I need feedback on > just to be safe). I don't understand way you don't use WITH_TESTS processed through bsd.own.mk. You'd presumably have to add it to the list of supported NO_* options for the bootstrap case, but that's trivial. Then you use could use normal MK_* variables. That would also let you use WITH(OUT)_TESTS in individual directories and they would always work. At a glance using WITHOUT_TESTS and NO_TEST internally would simplify some of the special cases in your patch. On a side note, I like the HMAKE change independent of the rest of the patch. -- Brooks --YZ5djTAD1cGYuMQK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iD8DBQFRdr4NXY6L6fI4GtQRAoJcAKCDe1KqUkRo/Jwss2TBwL8LEXWt4ACgyRqL FZmO4CxJZE5hRtxoE00tYH0= =gPvz -----END PGP SIGNATURE----- --YZ5djTAD1cGYuMQK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130423165958.GA91607>