Date: Tue, 26 Feb 2002 02:09:24 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Julian Elischer <julian@elischer.org> Cc: current@FreeBSD.org, dillon@FreeBSD.org Subject: Re: First (easy) td_ucred patch Message-ID: <XFMail.020226020924.jhb@FreeBSD.org> In-Reply-To: <Pine.BSF.4.21.0202231101130.79221-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23-Feb-02 Julian Elischer wrote: > > > On Fri, 22 Feb 2002, John Baldwin wrote: >> http://www.FreeBSD.org/~jhb/patches/ucred.patch >> > > The following diff removes the capacity to cope with the case when td is > NULL. I presume it is there because it CAN be NULL. (Though I have not > checked further.) No, it can't be NULL anymore. In 4.x, when we were idle, curproc could be null. In current we have an idle thread context, so we td can't be null except for very, _very_ early during startup which this code doesn't need to worry about. :) > --- //depot/vendor/freebsd/sys/fs/smbfs/smbfs_vnops.c 2001/12/20 > 08:43:46 > +++ //depot/projects/smpng/sys/fs/smbfs/smbfs_vnops.c 2002/02/21 > 15:55:47 > @@ -976,7 +976,6 @@ > caddr_t id = (caddr_t)1 /* ap->a_id */; > /* int flags = ap->a_flags;*/ > struct thread *td = curthread; > - struct proc *p = td ? td->td_proc : NULL; > struct smb_cred scred; > u_quad_t size; > off_t start, end, oadd; > @@ -1027,7 +1026,7 @@ > return EOVERFLOW; > end = start + oadd; > } > - smb_makescred(&scred, td, p ? p->p_ucred : NULL); > + smb_makescred(&scred, td, td->td_ucred); > switch (ap->a_op) { > case F_SETLK: > switch (fl->l_type) { > -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.020226020924.jhb>