From owner-svn-src-all@FreeBSD.ORG Tue Oct 27 21:11:33 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37EAF1065692; Tue, 27 Oct 2009 21:11:33 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (unknown [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id D2A438FC27; Tue, 27 Oct 2009 21:11:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id n9RL76XN083549; Tue, 27 Oct 2009 15:07:06 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 27 Oct 2009 15:07:19 -0600 (MDT) Message-Id: <20091027.150719.-1219478921.imp@bsdimp.com> To: mav@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <200910261123.n9QBNfJY087028@svn.freebsd.org> References: <200910261123.n9QBNfJY087028@svn.freebsd.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r198487 - head/sys/dev/ata X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2009 21:11:33 -0000 In message: <200910261123.n9QBNfJY087028@svn.freebsd.org> Alexander Motin writes: : Author: mav : Date: Mon Oct 26 11:23:41 2009 : New Revision: 198487 : URL: http://svn.freebsd.org/changeset/base/198487 : : Log: : Round timeout up when converting CAM milliseconds to ATA seconds. This implements ceil(timeout) rather than round(timeout). Is that intended? Warner : - request->timeout = ccb_h->timeout / 1000; /* XXX lost granularity */ : + request->timeout = (ccb_h->timeout + 999) / 1000; ... : - request->timeout = csio->ccb_h.timeout / 1000; : + request->timeout = (csio->ccb_h.timeout + 999) / 1000;