Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Aug 2009 14:49:08 +0200
From:      Ed Schouten <ed@80386.nl>
To:        Bruce Evans <brde@optusnet.com.au>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r196506 - in head/sys: kern sys
Message-ID:  <20090824124908.GF2829@hoeg.nl>
In-Reply-To: <20090824213600.T39644@delplex.bde.org>
References:  <200908241053.n7OArUhX092666@svn.freebsd.org> <20090824213600.T39644@delplex.bde.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Pgaa2uWPnPrfixyx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Bruce,

* Bruce Evans <brde@optusnet.com.au> wrote:
> CONS_DRIVER() was a good interface, unlike CONSOLE_DRIVER().  Removing it
> completes the bitrot in the support for cn_dbctl, and completes removal
> of cn_checkc's good name at the driver level.
>=20
> cn_dbctl is still needed to unbreak sysctl's support for ddb (see db_main=
=2Ec
> 1.4.2.1, which depends on cn_dbctl's infrastructure not having rotted) and
> can be used to unbreak polled i/o in all console drivers (not just in ddb
> mode -- it should have been named cn_ioctl) (see other mail).
>=20
> The higher level cngetc() and cncheckc() are still correctly named, now
> fully inconsistently with the driver level.

Well, there are lots of things broken in the current implementation.
Just take a look at how the cn_term is entirely commented out, only
because syscons can't handle it.

The only thing I tried to do with those changes, is remove dead code.
If someone comes up with patches to properly restore these features, I'd
be more than happy to commit them to SVN.

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--Pgaa2uWPnPrfixyx
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAkqSjEQACgkQ52SDGA2eCwWPcwCfYwppIstzj+QV2gRfcJyK0Ofe
7o8An2Pixj/3lmEpY0x/Gn8AvRhqok63
=OIU6
-----END PGP SIGNATURE-----

--Pgaa2uWPnPrfixyx--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090824124908.GF2829>