Date: Sun, 16 Mar 2003 22:31:11 +1100 From: Tim Robbins <tjr@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/udf udf_vnops.c Message-ID: <20030316223111.A84750@dilbert.robbins.dropbear.id.au> In-Reply-To: <200303161119.h2GBJsXQ091753@repoman.freebsd.org>; from tjr@FreeBSD.org on Sun, Mar 16, 2003 at 03:19:54AM -0800 References: <200303161119.h2GBJsXQ091753@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 16, 2003 at 03:19:54AM -0800, Tim J. Robbins wrote: > tjr 2003/03/16 03:19:54 PST > > FreeBSD src repository > > Modified files: > sys/fs/udf udf_vnops.c > Log: > Make udf_allocv() return an unlocked vnode instead of a locked one > to avoid a "locking against myself" panic when udf_hashins() tries > to lock it again. Lock the vnode in udf_hashins() before adding it to > the hash bucket. > > Revision Changes Path > 1.25 +1 -2 src/sys/fs/udf/udf_vnops.c It looks like there is a race between checking whether the vnode is already in the hash table, and allocating then adding it. It also looks like the cd9660 code that tries to avoid this race is broken. Anyone want to investigate these two? Tim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030316223111.A84750>