Date: Tue, 22 Apr 2003 23:30:56 -0700 (PDT) From: Nate Lawson <nate@root.org> To: Warner Losh <imp@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.cif_sis.c if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c if_wb.c if_xl.c Message-ID: <Pine.BSF.4.21.0304222323410.59938-100000@root.org> In-Reply-To: <20030421183416.0EB7A37B42F@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 21 Apr 2003, Warner Losh wrote: > Modified files: > sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c > if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c > if_wb.c if_xl.c > Log: > Use newly minted device_is_attached rather than device_is_alive to see > if attach succeeded. device_is_alive just tells us that probe > succeeded. Since we were using it to do things like detach net > interfaces, this caused problems when there were errors in the attach > routine. > > Symptoms of problem reported by: martin blapp Thank you for finding and fixing this. For fxp, I was testing this case by forcing the last call (bus_setup_irq()) to fail and loading/unloading the module in a loop. Everything still worked ok but there was definitely a leak in the busdma malloc pool. I'll see if this addresses that problem. -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0304222323410.59938-100000>