From owner-cvs-src@FreeBSD.ORG Tue Apr 22 23:30:55 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 155B637B405 for ; Tue, 22 Apr 2003 23:30:55 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id A239A43FD7 for ; Tue, 22 Apr 2003 23:30:53 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 60061 invoked by uid 1000); 23 Apr 2003 06:30:56 -0000 Date: Tue, 22 Apr 2003 23:30:56 -0700 (PDT) From: Nate Lawson To: Warner Losh In-Reply-To: <20030421183416.0EB7A37B42F@hub.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.cif_sis.c if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c if_wb.c if_xl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Apr 2003 06:30:55 -0000 On Mon, 21 Apr 2003, Warner Losh wrote: > Modified files: > sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c > if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c > if_wb.c if_xl.c > Log: > Use newly minted device_is_attached rather than device_is_alive to see > if attach succeeded. device_is_alive just tells us that probe > succeeded. Since we were using it to do things like detach net > interfaces, this caused problems when there were errors in the attach > routine. > > Symptoms of problem reported by: martin blapp Thank you for finding and fixing this. For fxp, I was testing this case by forcing the last call (bus_setup_irq()) to fail and loading/unloading the module in a loop. Everything still worked ok but there was definitely a leak in the busdma malloc pool. I'll see if this addresses that problem. -Nate