Date: Tue, 13 Oct 2009 21:54:09 -0700 From: Doug Barton <dougb@FreeBSD.org> To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= <des@des.no> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/varnish Makefile ports/www/varnish/files pkg-message.in varnishd.in varnishlog.in varnishncsa.in Message-ID: <4AD55971.3080506@FreeBSD.org> In-Reply-To: <86tyy2d1si.fsf@ds4.des.no> References: <200910131851.n9DIpB7P057665@repoman.freebsd.org> <4AD4DE92.3090808@FreeBSD.org> <86iqeietvu.fsf@ds4.des.no> <4AD551E2.3010407@FreeBSD.org> <86tyy2d1si.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smørgrav wrote: > Doug Barton <dougb@FreeBSD.org> writes: >> Dag-Erling Smørgrav <des@des.no> writes: >>> When does pre_start run? >> um, before start? :) After load_rc_config is what I think you're >> getting at. It's run as part of run_rc_command. >>> Does your patch allow the user to override varnishd_flags? >> Good point. I added that to the attached version. > > That's a lot of extra code for no percievable benefit... The if/else code is essentially the same as yours. Splitting out the flags that are common between your two options makes the code more readable. There is also the issue that code in rc.d scripts shouldn't run unconditionally, but I don't regard that as critical in this case since you're just setting variables. Ultimately it's up to you whether you want to accept the patches or not. I think they're useful but I am not going to make a stink about it. Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AD55971.3080506>