Date: Tue, 10 Jun 2014 18:45:23 -0400 From: Aryeh Friedman <aryeh.friedman@gmail.com> To: bz-noreply@freebsd.org Cc: freebsd-ports-bugs@freebsd.org Subject: Re: [Bug 185363] [NEW PORT] revive port devel/thistest Message-ID: <CAGBxaXk3iwTgocG44Zau7ytET1jUCKTy%2BBBy6wN6v_ESHwvEFw@mail.gmail.com> In-Reply-To: <bug-185363-13-cHpFDWb5Hv@https.bugs.freebsd.org/bugzilla/> References: <bug-185363-13@https.bugs.freebsd.org/bugzilla/> <bug-185363-13-cHpFDWb5Hv@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 10, 2014 at 6:38 PM, <bz-noreply@freebsd.org> wrote: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=185363 > > John Marino <marino@FreeBSD.org> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > CC| |marino@FreeBSD.org > > --- Comment #4 from John Marino <marino@FreeBSD.org> --- > I'm also confused, even after the patch-on-patch. > > The title says this replaces port "devel/thistest". > But the patch-on-patch says the new port is "devel/src-thistest-aegis" > which > seems kind of like nonsense to me. In fact, it seems like the name of the > port > follows the name of the tarball. > > Oh, and the original diff is not in unified patch format. > > > Is it STAGE safe? > > > To recap my concerns: > 1) The portname looks like it should be "thistest", not > "src-thistest-aegis" > (use DISTNAME to change name of distfile, not PORTNAME) > 2) It may not be jobs safe > 3) It's in two different patches, one of which isn't unified format > 4) The pkg-descr is still very weak (although to be fair the original > port's > description was also extremely weak) > 5) I'd like to hear that it was tested with poudriere > > If those were fixed, a brand new diff (or shar as is technically required, > but > I'm not going to) is submitted, and it has some reasonable testing then > I'll > pick this up. > > The should be fixed if they are not let me know > -- > You are receiving this mail because: > You are the assignee for the bug. > _______________________________________________ > freebsd-ports-bugs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs > To unsubscribe, send any mail to " > freebsd-ports-bugs-unsubscribe@freebsd.org" > -- Aryeh M. Friedman, Lead Developer, http://www.PetiteCloud.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGBxaXk3iwTgocG44Zau7ytET1jUCKTy%2BBBy6wN6v_ESHwvEFw>