From owner-freebsd-bluetooth@freebsd.org Tue Sep 22 20:38:59 2015 Return-Path: Delivered-To: freebsd-bluetooth@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 91A11A029BF for ; Tue, 22 Sep 2015 20:38:59 +0000 (UTC) (envelope-from erdgeist@erdgeist.org) Received: from elektropost.org (elektropost.org [217.115.13.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EF24F18E5 for ; Tue, 22 Sep 2015 20:38:58 +0000 (UTC) (envelope-from erdgeist@erdgeist.org) Received: (qmail 81323 invoked from network); 22 Sep 2015 20:38:49 -0000 Received: from elektropost.org (HELO elektropost.org) (erdgeist@erdgeist.org) by elektropost.org with ESMTPS (DHE-RSA-AES128-SHA encrypted); 22 Sep 2015 20:38:49 -0000 Subject: Re: Apple Magic Mouse To: Iain Hibbert References: <1437909200.57929.3.camel@yandex.com> <55F4362A.4050203@erdgeist.org> <55F60ED8.8080203@erdgeist.org> <55F78EB8.8060408@erdgeist.org> <55FCDBB6.6090004@erdgeist.org> <55FF08C5.1020509@erdgeist.org> Cc: "freebsd-bluetooth@freebsd.org" From: Dirk Engling X-Enigmail-Draft-Status: N1110 Message-ID: <5601BC58.9060200@erdgeist.org> Date: Tue, 22 Sep 2015 22:38:48 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2015 20:38:59 -0000 On 22.09.15 22:03, Iain Hibbert wrote: > in the rest of SDP code, these are styled SDP_ATTR_* is there a reason to > be different? No, when I first wrote that code for bthidd, there was no other SDP related code to steal from, so I never noticed there were naming conventions. Going to fix that in phabricator. > it is not required to credit the source of the information used to write > the handler for this device, but it is good practice to do so :) Frankly, I never thought about how code from now on gets it's proper attribution. Apple's proprietary report format now is only implicitly documented in code and I normally hate putting arbitrary integer offsets in code. But on the other hand I have the feeling that already there is too much non-generic code that does not even adhere to HID in a generic HID driver and this is without a magic track pad handler. That left me wondering if all of this should move to another object or maybe even out of the generic bthid driver. So I wonder how much documentation or reference to documentation is adequate. Also, how does one properly link to linux or netbsd driver source? erdgeist