From owner-cvs-src@FreeBSD.ORG Tue Aug 3 02:58:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D37F16A4D1 for ; Tue, 3 Aug 2004 02:58:13 +0000 (GMT) Received: from duchess.speedfactory.net (duchess.speedfactory.net [66.23.201.84]) by mx1.FreeBSD.org (Postfix) with SMTP id AEFA443D3F for ; Tue, 3 Aug 2004 02:58:12 +0000 (GMT) (envelope-from ups@tree.com) Received: (qmail 9696 invoked by uid 89); 3 Aug 2004 02:58:12 -0000 Received: from duchess.speedfactory.net (66.23.201.84) by duchess.speedfactory.net with SMTP; 3 Aug 2004 02:58:12 -0000 Received: (qmail 9680 invoked by uid 89); 3 Aug 2004 02:58:12 -0000 Received: from unknown (HELO palm.tree.com) (66.23.216.49) by duchess.speedfactory.net with SMTP; 3 Aug 2004 02:58:12 -0000 Received: from palm.tree.com (localhost.tree.com [127.0.0.1]) by palm.tree.com (8.12.10/8.12.10) with ESMTP id i732wAfY098990; Mon, 2 Aug 2004 22:58:11 -0400 (EDT) (envelope-from ups@palm.tree.com) Message-Id: <200408030258.i732wAfY098990@palm.tree.com> X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4 To: John Baldwin In-Reply-To: Message from John Baldwin of "Fri, 30 Jul 2004 15:32:24 EDT." <200407301532.24968.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 02 Aug 2004 22:58:10 -0400 From: Stephan Uphoff cc: Maxime Henrion cc: Brian Fundakowski Feldman cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_map.c vm_map.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2004 02:58:13 -0000 John Baldwin wrote: > On Friday 30 July 2004 12:06 pm, Brian Fundakowski Feldman wrote: > > On Fri, Jul 30, 2004 at 09:10:28AM +0000, Maxime Henrion wrote: > > > mux 2004-07-30 09:10:28 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/vm vm_map.c vm_map.h > > > Log: > > > Get rid of another lockmgr(9) consumer by using sx locks for the user > > > maps. We always acquire the sx lock exclusively here, but we can't > > > use a mutex because we want to be able to sleep while holding the > > > lock. This is completely equivalent to what we were doing with the > > > lockmgr(9) locks before. > > > > Not that I don't think it's worth doing in general, but is there a > > comparison anyone has done between speeds of sx and lockmgr? > > Speed aside, when allproc_lock and proctree_lock were lockmgr locks (before sx > was implemented), my SMP machines routinely locked up and when I looked at > things in the debugger it seemed that no one held allproc_lock but several > processes were blocked on it. Quite frankly, I don't trust lockmgr()'s > implementation. > Since the vfs layer forces me to use the lockmgr you scared me into taking a look. And yes there is a bug in the current implementation. (kern/69934). Stephan