Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 10 Oct 2011 21:34:55 -0400
From:      Sahil Tandon <sahil+cvs-ports@tandon.net>
To:        Andrey Chernov <ache@freebsd.org>, cvs-ports@FreeBSD.ORG, Eitan Adler <eadler@FreeBSD.ORG>, ports-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: ports/x11/luit Makefile distinfo ports/x11/luit/files patch-luit.c
Message-ID:  <20111011013455.GA21805@magic.hamla.org>
In-Reply-To: <20111011010644.GA19242@vniz.net>
References:  <201110101738.p9AHcHUq031559@repoman.freebsd.org> <20111010194330.GA94990@vniz.net> <CAF6rxgkUtYuYaUpM9M%2Bj8cXmg5yYVOZ5hMzFY5a_r%2BHoCkwAfA@mail.gmail.com> <20111010215854.GA96634@vniz.net> <20111011002607.GE21265@magic.hamla.org> <20111011010644.GA19242@vniz.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2011-10-11 at 05:06:45 +0400, Andrey Chernov wrote:

> On Mon, Oct 10, 2011 at 08:26:08PM -0400, Sahil Tandon wrote:
> > > It happens only if builded luit port have WITH_SETUID_LUIT set, otherwise 
> > > you don't notice the bug.
> > 
> > Ah, so it does not actually affect the default packages as built by the
> > clusters?
> 
> Yes, default packages are not affected, but building luit non-setuid by 
> default isn't a good choice in the first place due to this luit(1) quote:

That's fine and was never contested.

[ .. ]

> > Thanks; I believe eadler@ has already created a patch and shared it with
> > you for review.
> 
> Yes. There was single line, which is enough:
> CFLAGS+=	-DBSD

Correct.

-- 
Sahil Tandon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111011013455.GA21805>