Date: Wed, 3 Aug 2011 08:10:23 +0000 From: Ruslan Ermilov <ru@freebsd.org> To: d@delphij.net, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: weekly_catman not generating the right result? Message-ID: <20110803081023.GA91979@lo0.su> In-Reply-To: <20110731135700.GC11991@acme.spoerlein.net> References: <4E3510CC.8090300@delphij.net> <20110731121732.GB11991@acme.spoerlein.net> <4E354DFB.1020206@delphij.net> <20110731135700.GC11991@acme.spoerlein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jul 31, 2011 at 03:57:01PM +0200, Ulrich Spörlein wrote: > On Sun, 2011-07-31 at 05:43:39 -0700, Xin LI wrote: > > On 07/31/11 05:17, Ulrich Spörlein wrote: > > > On Sun, 2011-07-31 at 01:22:36 -0700, Xin LI wrote: > > >> Hi, > > >> > > >> I just noticed that weekly_catman is not generating the right > > >> result, e.g. instead of a highlight NAME, it gives 1mNAME0m (looks > > >> like the escape character is missing here). > > >> > > >> Is this a known issue? > > > > > > Now it is :) > > > > > > This is due to the recent changes that made groff emit ANSI > > > sequences and catman(1) is still putting col(1) in the pipe, which is > > > not really required and gobbles up part of the escape sequences. > > > > > > Please try the attached patch. Thanks. > > > > Thanks, that fixes the problem. > > > > Note that I noticed that setting PAGER to less won't work. Looking at > > my 8.2-RELEASE system, the rendered catpages are using ^H when > > highlighting while on -CURRENT it's an escape sequence (but I didn't see > > any change to nroff script nor catman itself)... > > The change that did this is r222648. You'll need to use `less -Rs' as > your PAGER/MANPAGER (or export LESS=-Rs). > > It's debatable if we want catpages to retain the old way of marking up > bold and underlined text. > > Ruslan: bsd.doc.mk was told to not use SGR in r222647, does it make > sense to do the same for catpages? This probably affects your patch that I've just reviewed, but I think you're right in that catpages should be in the old fashioned format. Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110803081023.GA91979>