Date: Tue, 4 Dec 2007 17:25:35 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: Dag-Erling Sm??rgrav <des@des.no>, John Birrell <jb@freebsd.org>, src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/netinet/libalias alias_util.c Message-ID: <20071204172535.GB82261@FreeBSD.org> In-Reply-To: <200712031657.34074.jhb@freebsd.org> References: <200711232356.lANNu3mp040885@repoman.freebsd.org> <864pezer7f.fsf@ds4.des.no> <200712031657.34074.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 03, 2007 at 04:57:33PM -0500, John Baldwin wrote: > On Monday 03 December 2007 10:24:52 am Dag-Erling Sm??rgrav wrote: > > John Birrell <jb@FreeBSD.org> writes: > > > Log: > > > Fix strict alias warnings. > > > > A much simpler solution (relative to the previous revision): > > > > @@ -131,10 +131,10 @@ > > sum += oddbyte; > > } > > /* "Pseudo-header" data */ > > - ptr = (u_short *) & (pip->ip_dst); > > + ptr = (void *)&pip->ip_dst; > > sum += *ptr++; > > sum += *ptr; > > - ptr = (u_short *) & (pip->ip_src); > > + ptr = (void *)&pip->ip_src; > > sum += *ptr++; > > sum += *ptr; > > sum += htons((u_short) ntcp); > > *ptr++ would choke since pointer arith on (void *) is undefined AFAIK. I've been under impression that ++ on void * whould simply increase it by one. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071204172535.GB82261>