Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Mar 2014 14:07:15 +1100 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Eitan Adler <eadler@freebsd.org>
Subject:   Re: svn commit: r262882 - head/tools/tools/net80211/wlanstats
Message-ID:  <20140307132653.O3656@besplex.bde.org>
In-Reply-To: <20140307020210.GA38155@FreeBSD.org>
References:  <201403070123.s271Nn1b019719@svn.freebsd.org> <20140307020210.GA38155@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 7 Mar 2014, Alexey Dokuchaev wrote:

> On Fri, Mar 07, 2014 at 01:23:49AM +0000, Eitan Adler wrote:
>> New Revision: 262882
>> URL: http://svnweb.freebsd.org/changeset/base/262882
>>
>> Log:
>>   wlanstats: add help
>>
>>   - add a help (-h) flag
>>   - move usage into itsown function
>
> it looks like the only change now is that usage info always go to stdout,
> and exit code differs.  i don't think it should be mfced.

It also removes the double printing of the program name (correct) and the
printing of "usage: ", and has mounds of style bugs.

gnu utilities have a --help flag that causes similar behaviour (printing
to stdout and exiting with status 0), but they still print error messages
about usage to stderr.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140307132653.O3656>