Date: Mon, 4 Apr 2011 01:51:24 +0200 From: Victor Balada Diaz <victor@bsdes.net> To: Mikolaj Golub <trociny@freebsd.org> Cc: Kostik Belousov <kib@FreeBSD.org>, stable@freebsd.org, Pawel Jakub Dawidek <pjd@FreeBSD.org> Subject: Re: geli(4) memory leak Message-ID: <20110403235124.GF1289@equilibrium.bsdes.net> In-Reply-To: <86zko7nsby.fsf@kopusha.home.net> References: <20110326003348.GQ36706@equilibrium.bsdes.net> <20110401174354.GE1289@equilibrium.bsdes.net> <86pqp53cqe.fsf@kopusha.home.net> <20110402101750.GD1849@garage.freebsd.pl> <86zko7nsby.fsf@kopusha.home.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Apr 03, 2011 at 08:43:45PM +0300, Mikolaj Golub wrote: > > On Sat, 2 Apr 2011 12:17:50 +0200 Pawel Jakub Dawidek wrote: > > PJD> On Sat, Apr 02, 2011 at 12:04:09AM +0300, Mikolaj Golub wrote: > >> For me your patch look correct. But the same issue is for read :-). Also, to > >> avoid the leak I think we can just do g_destroy_bio() before "all sectors" > >> check. See the attached patch (had some testing). > > PJD> The patch looks good. Please commit. > > Commited, thanks. I've been out all the weekend, so i've been unable to answer before. I'm glad it got commited and it's great you discovered and fixed the same problem on the read path. Are there any plans to MFC this? Thanks a lot. Regards. -- La prueba más fehaciente de que existe vida inteligente en otros planetas, es que no han intentado contactar con nosotros.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110403235124.GF1289>