Date: Sat, 16 Sep 1995 15:42:30 +1000 From: Stephen McKay <syssgm@devetir.qld.gov.au> To: FreeBSD-gnats-submit@freebsd.org Cc: syssgm@devetir.qld.gov.au Subject: bin/722: Off-by-one error in wbkgd() in ncurses Message-ID: <199509160542.PAA02308@stupid.devetir.qld.gov.au> Resent-Message-ID: <199509160610.XAA00193@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 722
>Category: bin
>Synopsis: Off-by-one error in wbkgd() in ncurses
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Sep 15 23:10:01 PDT 1995
>Last-Modified:
>Originator: Paul Koch
>Organization:
>Release: FreeBSD 2.2-CURRENT i386
>Environment:
FreeBSD 2.0.5 on a 16Mb 486DX50
>Description:
[ I'm posting this for Paul Koch, who has no net connection. ]
I found when using the ncurses library call 'wbkgd', the entire
background was not being painted properly. eg on a 80*25 window,
the last column and last line were being painted incorrectly.
>How-To-Repeat:
>Fix:
*** libncurses/lib_bkgd.c.old Mon Sep 4 12:56:29 1995
--- libncurses/lib_bkgd.c Mon Sep 4 12:57:11 1995
***************
*** 25,32 ****
int x, y;
T(("wbkgd(%x, %x) called", win, ch));
! for (y = 0; y < win->_maxy; y++)
! for (x = 0; x < win->_maxx; x++)
if (win->_line[y][x]&A_CHARTEXT == ' ')
win->_line[y][x] |= ch;
else
--- 25,32 ----
int x, y;
T(("wbkgd(%x, %x) called", win, ch));
! for (y = 0; y <= win->_maxy; y++)
! for (x = 0; x <= win->_maxx; x++)
if (win->_line[y][x]&A_CHARTEXT == ' ')
win->_line[y][x] |= ch;
else
EOF
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199509160542.PAA02308>