Date: Sat, 17 May 2008 12:15:07 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Marcel Moolenaar <marcel@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/puc pucdata.c Message-ID: <200805171215.07353.jhb@freebsd.org> In-Reply-To: <200805161457.m4GEvnmS013697@repoman.freebsd.org> References: <200805161457.m4GEvnmS013697@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 16 May 2008 10:57:49 am Marcel Moolenaar wrote: > marcel 2008-05-16 14:57:49 UTC > > FreeBSD src repository > > Modified files: > sys/dev/puc pucdata.c > Log: > Fix RID calculation. The RID is really the BAR for PCI cards, > so the index needs to be translated into an offset. While we > did add the offset (0x10), we forgot to account for the width. > > Tested by: Thomas Vogt > MFC after: 3 days Perhaps use the PCIR_BAR() macro to map BARs indices to RIDs? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200805171215.07353.jhb>