Date: Fri, 8 Nov 2019 05:52:47 +0100 From: Tobias Kortkamp <tobik@freebsd.org> To: Niclas Zeising <zeising@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r516921 - head/Mk/Uses Message-ID: <20191108045247.GA82122@urd.tobik.me> In-Reply-To: <201911061902.xA6J2hV6031987@repo.freebsd.org> References: <201911061902.xA6J2hV6031987@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--qDbXVdCdHGoSgWSk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 06, 2019 at 07:02:43PM +0000, Niclas Zeising wrote: > Author: zeising > Date: Wed Nov 6 19:02:42 2019 > New Revision: 516921 > URL: https://svnweb.freebsd.org/changeset/ports/516921 >=20 > Log: > Mk/Uses: Add USES+=3Dxorg when including xorg.mk > =20 > Add USES+=3Dxorg to the places where MK/Uses/xorg.mk is included from o= ther > files in the Uses infrastructure. This is done to silence an erroneous > warning about USES=3Dxorg not being set when using USES=3Dgl, motif or = xorg-cat, > even when it's included from the framework. > =20 > This is a different proposal than what was originally suggested in pr 2= 41627 > and https://reviews.freebsd.org/D22210 . > =20 > PR: 238988, 241627 > Discussed with: mat > MFH: 2019Q4 > Differential Revision: https://reviews.freebsd.org/D22210 Something is still wrong. A port with for example USES=3D gl USE_GL=3D glut will still give the bogus warning. It goes away with: Index: Mk/Uses/gl.mk =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- Mk/Uses/gl.mk (revision 517030) +++ Mk/Uses/gl.mk (working copy) @@ -40,7 +40,9 @@ .if !defined(_GL_${_component}_LIB_DEPENDS) IGNORE=3D uses unknown GL component .else +.if defined(_GL_${_component}_USE_XORG) USE_XORG+=3D ${_GL_${_component}_USE_XORG} +.endif LIB_DEPENDS+=3D ${_GL_${_component}_LIB_DEPENDS} .endif .endfor --qDbXVdCdHGoSgWSk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl3E9JtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2F1Zgf+OPu2y683tlZgGcC4PcSakXzAOVQ/h0VcDKv5dA+na37CziTe/QXKB3Cu /WVql/s++KOFIfhWqoGWyL2wtKbspqzE6l8H/XLXLn75rJg3kDuV/mjJRyn4FrsC 2tuimH8m2FJG4sH99PFB3x5suXQJ8ctA51brYMTz7Zs+f3XJuevIkffKplYH5vlW THWMK0l8xPoDbZF6/Lh3utoHwbgpgtvL0esFaTBGEJvtFwJkO7gt3f2C0W0nmBtC KV6PyjYLGtJnTJspgL4SpIaL+sdSNWv353xHIJVfmAlqEjg9fMonHYSAF6CXZ2Ov emtFHfXEvPYOPocmG1falujx+pwBAA== =zJef -----END PGP SIGNATURE----- --qDbXVdCdHGoSgWSk--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191108045247.GA82122>